This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][SVE] Add bfloat16 support to svext intrinsic
ClosedPublic

Authored by c-rhodes on Jun 23 2020, 9:44 AM.

Diff Detail

Event Timeline

c-rhodes created this revision.Jun 23 2020, 9:44 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 23 2020, 9:44 AM
fpetrogalli accepted this revision.Jun 24 2020, 7:27 AM

LGTM! Thank you.

This revision is now accepted and ready to land.Jun 24 2020, 7:27 AM
fpetrogalli requested changes to this revision.Jun 24 2020, 2:28 PM

Putting it on hold as we need to guard those patterns with HasBF16.

This revision now requires changes to proceed.Jun 24 2020, 2:28 PM
c-rhodes updated this revision to Diff 273365.Jun 25 2020, 8:03 AM

Changes:

  • Guard patterns on +bf16.
fpetrogalli accepted this revision.Jun 25 2020, 8:17 AM

LGTM, thank you!

This revision is now accepted and ready to land.Jun 25 2020, 8:17 AM
sdesmalen added inline comments.Jun 25 2020, 9:12 AM
llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td
1479

These patterns are missing tests in llvm/test/CodeGen/AArch64/sve-bitcast.ll

c-rhodes updated this revision to Diff 273685.Jun 26 2020, 5:17 AM

Changes:

  • Add tests for bfloat bitcast patterns.
c-rhodes marked an inline comment as done.Jun 26 2020, 5:17 AM
This revision was automatically updated to reflect the committed changes.