Page MenuHomePhabricator

[libc++] Require concepts support for <numbers>
ClosedPublic

Authored by ldionne on Jun 19 2020, 2:48 AM.

Details

Summary

Similar to <concepts> we need to protect the header and test against inclusion and being run if concepts aren't supported by the compiler.

Diff Detail

Event Timeline

tambre created this revision.Jun 19 2020, 2:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2020, 2:48 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
tambre added a reviewer: EricWF.EditedJun 19 2020, 2:49 AM

D77505 broke a bunch of bots. This fixes the regression.

I lack commit privileges. Please land as "Raul Tambre <raul@tambre.ee>"

D77505 broke a bunch of bots. This fixes the regression.

I lack commit privileges. Please land as "Raul Tambre <raul@tambre.ee>"

you need to fix this test file too libcxx/test/std/language.support/support.limits/support.limits.general/numbers.version.pass.cpp.

ldionne commandeered this revision.Jun 19 2020, 7:40 AM
ldionne edited reviewers, added: tambre; removed: ldionne.
ldionne updated this revision to Diff 272075.Jun 19 2020, 7:48 AM

Fix feature-test macro generation

ldionne accepted this revision.Jun 19 2020, 7:49 AM
ldionne marked an inline comment as done.

Thanks @tambre , going to commit this now.

libcxx/utils/generate_feature_test_macro_components.py
607

@tambre This is the part that was missing. I added that and re-generated the files.

This revision is now accepted and ready to land.Jun 19 2020, 7:49 AM
This revision was automatically updated to reflect the committed changes.