This is an archive of the discontinued LLVM Phabricator instance.

Differential D82169

Don't install clang-import-test
ClosedPublic

Authored by arichardson on Jun 19 2020, 2:37 AM.

Details

Reviewers
spyffe
bruno
lhames
v.g.vassilev
loladiro
Commits
rG2ace69339ffe: Don't install clang-import-test
Summary

I have been trying to reduce the installed size of our CHERI toolchain and
noticed that this tool was being installed even with -DLLVM_INSTALL_TOOLCHAIN_ONLY=ON.
This appears to be a test binary that should not be installed.

Diff Detail

Event Timeline

arichardson created this revision.Jun 19 2020, 2:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2020, 2:37 AM
Herald added subscribers: cfe-commits, dexonsmith, mgorny. · View Herald Transcript
Harbormaster completed remote builds in B60976: Diff 271970.Jun 19 2020, 3:44 AM
v.g.vassilev accepted this revision.Jun 22 2020, 12:37 AM

Makes sense to me!

This revision is now accepted and ready to land.Jun 22 2020, 12:37 AM
Closed by commit rG2ace69339ffe: Don't install clang-import-test (authored by arichardson). · Explain WhyJun 24 2020, 4:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang/
tools/
clang-import-test/
2 lines

Diff 272981

clang/tools/clang-import-test/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Core Core
Support Support
) )
if(NOT CLANG_BUILT_STANDALONE) if(NOT CLANG_BUILT_STANDALONE)
set(tablegen_deps intrinsics_gen) set(tablegen_deps intrinsics_gen)
endif() endif()
add_clang_tool(clang-import-test add_clang_executable(clang-import-test
clang-import-test.cpp clang-import-test.cpp
DEPENDS DEPENDS
${tablegen_deps} ${tablegen_deps}
) )
set(CLANG_IMPORT_TEST_LIB_DEPS set(CLANG_IMPORT_TEST_LIB_DEPS
clangAST clangAST
clangBasic clangBasic
Show All 12 Lines