Page MenuHomePhabricator

spyffe (Sean Callanan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 23 2015, 1:30 PM (234 w, 6 d)

Recent Activity

Sep 28 2017

spyffe committed rL314458: [Expression parser] Setting to enable use of ExternalASTMerger.
[Expression parser] Setting to enable use of ExternalASTMerger
Sep 28 2017, 1:22 PM

Sep 27 2017

spyffe committed rL314336: Add support for remembering origins to ExternalASTMerger.
Add support for remembering origins to ExternalASTMerger
Sep 27 2017, 12:59 PM
spyffe closed D38208: Add support for remembering origins to ExternalASTMerger by committing rL314336: Add support for remembering origins to ExternalASTMerger.
Sep 27 2017, 12:59 PM · Restricted Project

Sep 26 2017

spyffe committed rL314225: [Expression Parser] Inhibit global lookups for symbols in the IR dynamic checks.
[Expression Parser] Inhibit global lookups for symbols in the IR dynamic checks
Sep 26 2017, 3:34 PM
spyffe closed D38153: Inhibit global lookups for symbols in the IR dynamic checks by committing rL314225: [Expression Parser] Inhibit global lookups for symbols in the IR dynamic checks.
Sep 26 2017, 3:34 PM · Restricted Project
spyffe abandoned D38153: Inhibit global lookups for symbols in the IR dynamic checks.

Committed as LLDB r314225

Sep 26 2017, 3:30 PM · Restricted Project
spyffe updated the diff for D38208: Add support for remembering origins to ExternalASTMerger.

Updates and small refactors requested by Bruno.

Sep 26 2017, 3:30 PM · Restricted Project

Sep 25 2017

spyffe updated the diff for D38153: Inhibit global lookups for symbols in the IR dynamic checks.

Applied Greg's and Zachary's suggestions:

Sep 25 2017, 5:02 AM · Restricted Project
spyffe abandoned D36589: Add support for remembering origins to ExternalASTMerger.

At @bruno 's request, abandoning this revision in favor of the updated https://reviews.llvm.org/D38208.
That revision has all the changes requested.

Sep 25 2017, 5:02 AM · Restricted Project
spyffe created D38208: Add support for remembering origins to ExternalASTMerger.
Sep 25 2017, 5:02 AM · Restricted Project
spyffe added a comment to D38153: Inhibit global lookups for symbols in the IR dynamic checks.

Thank you. I am testing a new revision with your suggestions.

Sep 25 2017, 5:02 AM · Restricted Project
spyffe updated the diff for D36589: Add support for remembering origins to ExternalASTMerger.

Updated to reflect Bruno's suggestions.

Sep 25 2017, 5:02 AM · Restricted Project

Sep 21 2017

spyffe created D38153: Inhibit global lookups for symbols in the IR dynamic checks.
Sep 21 2017, 1:54 PM · Restricted Project

Sep 18 2017

spyffe updated the diff for D36589: Add support for remembering origins to ExternalASTMerger.

Added DEBUG_PRINTF code to enable introspection into what's happening.

Sep 18 2017, 2:05 PM · Restricted Project

Aug 23 2017

spyffe updated the diff for D36589: Add support for remembering origins to ExternalASTMerger.

Removed unnecessary code and improved code coverage. Also made a few operational changes:

Aug 23 2017, 1:59 PM · Restricted Project

Aug 16 2017

spyffe updated the diff for D36589: Add support for remembering origins to ExternalASTMerger.

Added more tests, and added an option to clang-import-test to actually use the origin-forwarding code. Also fixed some errors in CompleteType that were caught by these new tests.

Aug 16 2017, 9:41 AM · Restricted Project

Aug 14 2017

spyffe updated the diff for D36589: Add support for remembering origins to ExternalASTMerger.

Updated the patch to make it possible for external clients to record the origins of types manually, a requirement for LLDB.

Aug 14 2017, 12:53 PM · Restricted Project

Aug 10 2017

spyffe updated the diff for D36589: Add support for remembering origins to ExternalASTMerger.

Updated the patch to eliminate the need to pass in an OriginMap for the target. The OriginMap can be extracted afterward, and merged by other algorithms if necessary.

Aug 10 2017, 5:48 PM · Restricted Project
spyffe created D36589: Add support for remembering origins to ExternalASTMerger.
Aug 10 2017, 12:51 PM · Restricted Project

Aug 7 2017

spyffe committed rL310318: This adds the argument --dump-ir to clang-import-test, which allows .
This adds the argument --dump-ir to clang-import-test, which allows
Aug 7 2017, 3:28 PM
spyffe closed D36429: [clang-import-test] Option to dump the IR for an expression by committing rL310318: This adds the argument --dump-ir to clang-import-test, which allows .
Aug 7 2017, 3:28 PM
spyffe updated the diff for D36429: [clang-import-test] Option to dump the IR for an expression.

Eliminate sensitive dependence on sizeof(int). bool should still be rendered as i1 though.

Aug 7 2017, 2:47 PM
spyffe updated the diff for D36429: [clang-import-test] Option to dump the IR for an expression.

Added a passing test for a global struct, so we have something that'll fail if the IR dumping breaks.

Aug 7 2017, 2:43 PM
spyffe created D36429: [clang-import-test] Option to dump the IR for an expression.
Aug 7 2017, 2:36 PM

Aug 1 2017

spyffe committed rL309714: xfail test_get_process_info pending bot fixes.
xfail test_get_process_info pending bot fixes
Aug 1 2017, 10:45 AM
spyffe committed rL309702: [build system] Add SBProcessInfo to the xcodeproj.
[build system] Add SBProcessInfo to the xcodeproj
Aug 1 2017, 10:10 AM

Jul 31 2017

spyffe committed rL309631: [build-script] Bring in modernizations from downstream:.
[build-script] Bring in modernizations from downstream:
Jul 31 2017, 2:51 PM

Jul 25 2017

spyffe committed rL309046: Skip test_unique_stacks on Darwin, because it doesn't terminate reliably..
Skip test_unique_stacks on Darwin, because it doesn't terminate reliably.
Jul 25 2017, 3:45 PM
spyffe committed rL309018: Fix a bot by linking clang-import-test against libclangDriver.
Fix a bot by linking clang-import-test against libclangDriver
Jul 25 2017, 1:10 PM
spyffe committed rL309014: [ExternalASTMerger] Import Objective-C classes.
[ExternalASTMerger] Import Objective-C classes
Jul 25 2017, 12:55 PM
spyffe closed D35274: [ExternalASTMerger] Import Objective-C classes by committing rL309014: [ExternalASTMerger] Import Objective-C classes.
Jul 25 2017, 12:55 PM
spyffe committed rL308993: [TypeSystem] Guard the global `ASTSourceMap` with a mutex.
[TypeSystem] Guard the global `ASTSourceMap` with a mutex
Jul 25 2017, 10:34 AM
spyffe closed D35083: [TypeSystem] Guard the global `ASTSourceMap` with a mutex by committing rL308993: [TypeSystem] Guard the global `ASTSourceMap` with a mutex.
Jul 25 2017, 10:34 AM

Jul 24 2017

spyffe committed rL308919: Skip test_lldbmi_var_update on Darwin..
Skip test_lldbmi_var_update on Darwin.
Jul 24 2017, 1:11 PM

Jul 11 2017

spyffe created D35274: [ExternalASTMerger] Import Objective-C classes.
Jul 11 2017, 1:43 PM
spyffe updated the diff for D35083: [TypeSystem] Guard the global `ASTSourceMap` with a mutex.

Upon reflection, it's not worth coming up with a new pattern if

Jul 11 2017, 1:30 PM

Jul 10 2017

spyffe committed rL307603: [clang-import-test] Test that enumerators and their values are found..
[clang-import-test] Test that enumerators and their values are found.
Jul 10 2017, 5:30 PM
spyffe committed rL307602: [clang-import-test] Committed missed update to clang-import-test.cpp.
[clang-import-test] Committed missed update to clang-import-test.cpp
Jul 10 2017, 5:28 PM
spyffe committed rL307600: clang-import-test had some dead code. I did the following to eliminate it:.
clang-import-test had some dead code. I did the following to eliminate it:
Jul 10 2017, 4:47 PM
spyffe closed D35220: [clang-import-test] Improve coverage by adding a test and eliminating dead code by committing rL307600: clang-import-test had some dead code. I did the following to eliminate it:.
Jul 10 2017, 4:47 PM
spyffe updated the diff for D35220: [clang-import-test] Improve coverage by adding a test and eliminating dead code.

Eliminated a useless Expected.

Jul 10 2017, 3:58 PM
spyffe added inline comments to D35220: [clang-import-test] Improve coverage by adding a test and eliminating dead code.
Jul 10 2017, 2:47 PM
spyffe created D35220: [clang-import-test] Improve coverage by adding a test and eliminating dead code.
Jul 10 2017, 1:24 PM

Jul 9 2017

spyffe added a comment to D35083: [TypeSystem] Guard the global `ASTSourceMap` with a mutex.

Responded to Lang's comments inline.

Jul 9 2017, 6:13 AM

Jul 6 2017

spyffe created D35083: [TypeSystem] Guard the global `ASTSourceMap` with a mutex.
Jul 6 2017, 1:26 PM

Jun 29 2017

spyffe committed rL306773: [Data formatters] Make NSSetM support both old- and new-style representation.
[Data formatters] Make NSSetM support both old- and new-style representation
Jun 29 2017, 5:39 PM
spyffe closed D34821: [Data formatters] Make NSSetM support both old- and new-style representation by committing rL306773: [Data formatters] Make NSSetM support both old- and new-style representation.
Jun 29 2017, 5:39 PM
spyffe created D34821: [Data formatters] Make NSSetM support both old- and new-style representation.
Jun 29 2017, 11:03 AM

Jun 28 2017

spyffe committed rL306611: Added a project for the unified IR interpreter..
Added a project for the unified IR interpreter.
Jun 28 2017, 3:51 PM

Jun 27 2017

spyffe committed rL306460: [build system] If there's an OVERRIDE, don't guess the current SCM..
[build system] If there's an OVERRIDE, don't guess the current SCM.
Jun 27 2017, 1:36 PM

Jun 23 2017

spyffe committed rL306180: Updated the NSArray and NSDictionary formatters to support new storage formats..
Updated the NSArray and NSDictionary formatters to support new storage formats.
Jun 23 2017, 4:16 PM

Jun 20 2017

spyffe accepted D34371: Preserve CXX method overrides in ASTImporter.

Looks good to me. Upon reflection, I think it's more important to adhere to the standard of the surrounding code in the ASTDumper, otherwise you're hurting reusability.

Jun 20 2017, 1:53 PM
spyffe requested changes to D34371: Preserve CXX method overrides in ASTImporter.

Thanks for working on this! I have a few requests (some may arise from ignorance of capture semantics).

Jun 20 2017, 10:51 AM

Jun 19 2017

spyffe committed rL305727: Updated NSNumber formatter for new internal representation..
Updated NSNumber formatter for new internal representation.
Jun 19 2017, 11:33 AM

Jun 16 2017

spyffe added a comment to D6550: ASTImporter: Fix missing SourceLoc imports.

Hmm, the transforming in place of SelLocs reads a little weirdly to me, but other than that the code seems fine.
Is your concern that you don't know how to write an Objective-C test that would cover this? It looks to me like an Objective-C interface with a method:

@interface MyClass { }
-(int)addInt:(int)a toInt:(int)b moduloInt:(int)c;
@end

might be enough for an ASTMerge test. If you want to make clang-import-test use this code, then we might need to add one or two things into that tester to handle Objective-C method lookup.

Jun 16 2017, 11:11 AM
spyffe accepted D34253: Call setMustBuildLookupTable on TagDecls in ExternalASTMerger.

Thanks for the test. This looks fine.

Jun 16 2017, 10:09 AM

Jun 14 2017

spyffe committed rL305424: [testsuite] xfailed two tests that depend on NSString conforming to NSCopying..
[testsuite] xfailed two tests that depend on NSString conforming to NSCopying.
Jun 14 2017, 4:02 PM
spyffe requested changes to D32947: [ASTImporter] FriendDecl importing improvements.

Sorry for the late review, I saw your ping but the last week was busy. Anyway, thanks for the tests!

Jun 14 2017, 10:56 AM

Jun 1 2017

spyffe committed rL304510: [TypeSystem] Handle Clang AttributedTypes.
[TypeSystem] Handle Clang AttributedTypes
Jun 1 2017, 6:24 PM
spyffe closed D33812: [TypeSystem] Handle Clang AttributedTypes by committing rL304510: [TypeSystem] Handle Clang AttributedTypes.
Jun 1 2017, 6:24 PM
spyffe added a comment to D33812: [TypeSystem] Handle Clang AttributedTypes.

ModifiedType gets assigned during construction and getModifiedType() is just an accessor, so if that is nullptr something very bad is happening. We should not expect that except in case of a parser bug of some sort.

Jun 1 2017, 6:10 PM
spyffe created D33812: [TypeSystem] Handle Clang AttributedTypes.
Jun 1 2017, 5:15 PM

May 31 2017

spyffe committed rL304314: Added a testcase for local/namespaced name conflicts..
Added a testcase for local/namespaced name conflicts.
May 31 2017, 10:18 AM

May 16 2017

spyffe committed rL303223: [Expression parser] Look up module symbols before hunting globally.
[Expression parser] Look up module symbols before hunting globally
May 16 2017, 4:59 PM
spyffe closed D33083: [Expression parser] Look up module symbols before hunting globally by committing rL303223: [Expression parser] Look up module symbols before hunting globally.
May 16 2017, 4:59 PM
spyffe updated the diff for D33083: [Expression parser] Look up module symbols before hunting globally.

Used CFLAGS_EXTRAS instead of CFLAGS at Greg Clayton's suggestion.

May 16 2017, 3:01 PM
spyffe updated the diff for D33083: [Expression parser] Look up module symbols before hunting globally.

Updated to reflect Pavel Labath's suggestions:

May 16 2017, 1:31 PM

May 15 2017

spyffe updated the diff for D33083: [Expression parser] Look up module symbols before hunting globally.

Two changes after Greg and Pavel's suggestions:

May 15 2017, 5:11 PM
spyffe closed D33077: [TypeSystem] Fix inspection of Objective-C object types.

Committed r303110.

May 15 2017, 1:12 PM
spyffe committed rL303110: [TypeSystem] Fix inspection of Objective-C object types.
[TypeSystem] Fix inspection of Objective-C object types
May 15 2017, 1:08 PM
spyffe updated the diff for D33077: [TypeSystem] Fix inspection of Objective-C object types.

Updated the Makefile to fix a problem caught by Pavel Labath.
Also relocated the new test to lang/objc.

May 15 2017, 1:07 PM

May 12 2017

spyffe committed rL302975: [ASTImporter] Improve handling of incomplete types.
[ASTImporter] Improve handling of incomplete types
May 12 2017, 6:00 PM
spyffe added inline comments to D32981: [ASTImporter] Improve handling of incomplete types .
May 12 2017, 3:15 PM
spyffe committed rL302954: Fixed the OS X build after Error -> Status rename..
Fixed the OS X build after Error -> Status rename.
May 12 2017, 3:07 PM

May 11 2017

spyffe committed rL302850: xfail TestClassTemplateParameterPack on gcc to mollify lldb-x86_64-ubuntu-14.04….
xfail TestClassTemplateParameterPack on gcc to mollify lldb-x86_64-ubuntu-14.04…
May 11 2017, 4:51 PM
spyffe committed rL302833: [DWARF parser] Produce correct template parameter packs.
[DWARF parser] Produce correct template parameter packs
May 11 2017, 3:21 PM
spyffe closed D33025: [DWARF parser] Produce correct template parameter packs by committing rL302833: [DWARF parser] Produce correct template parameter packs.
May 11 2017, 3:21 PM
spyffe updated the diff for D33083: [Expression parser] Look up module symbols before hunting globally.

Improved symbol lookup per Greg and Jim's suggestion, with flipped steps 2 and 3.
Also added testing for the error case.

May 11 2017, 1:23 PM
spyffe added a comment to D33083: [Expression parser] Look up module symbols before hunting globally.

I also would flip 2 and 3. I'll give this a shot.

May 11 2017, 10:54 AM

May 10 2017

spyffe created D33083: [Expression parser] Look up module symbols before hunting globally.
May 10 2017, 6:48 PM
spyffe created D33077: [TypeSystem] Fix inspection of Objective-C object types.
May 10 2017, 3:40 PM
spyffe added inline comments to D32981: [ASTImporter] Improve handling of incomplete types .
May 10 2017, 11:22 AM
spyffe updated the diff for D32981: [ASTImporter] Improve handling of incomplete types .

• Added a FIXME per Aleksei Sidorin's suggestion.

May 10 2017, 11:21 AM

May 9 2017

spyffe created D33025: [DWARF parser] Produce correct template parameter packs.
May 9 2017, 7:38 PM
spyffe added a reviewer for D32981: [ASTImporter] Improve handling of incomplete types : bruno.
May 9 2017, 10:32 AM

May 8 2017

spyffe updated the diff for D32981: [ASTImporter] Improve handling of incomplete types .

Eliminated a missing newline at end of file error

May 8 2017, 2:59 PM
spyffe created D32981: [ASTImporter] Improve handling of incomplete types .
May 8 2017, 2:56 PM
spyffe added inline comments to D32724: [Modules] Handle sanitizer feature mismatches when importing modules.
May 8 2017, 10:47 AM

May 5 2017

spyffe requested changes to D32724: [Modules] Handle sanitizer feature mismatches when importing modules.

A few minor nits, but the operation of ignoring certain sanitizer flags seems to be happening in the wrong place.

May 5 2017, 3:44 PM

May 2 2017

spyffe committed rL301993: Fixed a bug where we did not properly use the complete versions of Objective-C….
Fixed a bug where we did not properly use the complete versions of Objective-C…
May 2 2017, 5:54 PM

Apr 27 2017

spyffe committed rL301573: Added an Importer test for in-class member initializers..
Added an Importer test for in-class member initializers.
Apr 27 2017, 11:23 AM

Apr 26 2017

spyffe committed rL301461: Fixed a crash when dealing with an empty method name in the ObjC runtime..
Fixed a crash when dealing with an empty method name in the ObjC runtime.
Apr 26 2017, 1:49 PM

Apr 24 2017

spyffe committed rL301280: Name the C++ source files for two tests correctly..
Name the C++ source files for two tests correctly.
Apr 24 2017, 5:11 PM
spyffe committed rL301277: Fixed two bad Makefiles that might be breaking Linux..
Fixed two bad Makefiles that might be breaking Linux.
Apr 24 2017, 5:02 PM
spyffe closed D32100: [Expression parser] Return both types and variables.

Closed by r301273

Apr 24 2017, 4:27 PM
spyffe committed rL301273: [Expression parser] Return both types and variables.
[Expression parser] Return both types and variables
Apr 24 2017, 4:27 PM
spyffe committed rL301263: [DWARF] Fix lookup in the abstract origins of inlined blocks/functions.
[DWARF] Fix lookup in the abstract origins of inlined blocks/functions
Apr 24 2017, 3:24 PM
spyffe closed D32375: [DWARF] Fix lookup in the abstract origins of inlined blocks/functions by committing rL301263: [DWARF] Fix lookup in the abstract origins of inlined blocks/functions.
Apr 24 2017, 3:24 PM · Restricted Project
spyffe added inline comments to D32375: [DWARF] Fix lookup in the abstract origins of inlined blocks/functions.
Apr 24 2017, 1:57 PM · Restricted Project
spyffe accepted D31777: [ASTImporter] Move structural equivalence context to its own file. NFCI.

Looks good to me. This is a good step toward simplifying the ASTImporter and breaking out its parts to be useful on their own.
Obviously make sure the tests pass :)

Apr 24 2017, 1:34 PM