This is an archive of the discontinued LLVM Phabricator instance.

[MLIR][Shape] Realize `shape` to `std` lowering with declarative patterns
ClosedPublic

Authored by frgossen on Jun 17 2020, 8:59 AM.

Details

Summary

Setup declarative rewrite rules to lower the shape dialect to the std
dialect with two exemplary rules for from/to_extent_tensor.

Diff Detail

Event Timeline

frgossen created this revision.Jun 17 2020, 8:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 17 2020, 8:59 AM
pifon2a accepted this revision.Jun 17 2020, 9:16 AM

thanks!

mlir/lib/Conversion/ShapeToStandard/ShapeToStandard.cpp
22

you can also move it right before populate...() function

This revision is now accepted and ready to land.Jun 17 2020, 9:16 AM
bondhugula added inline comments.
mlir/lib/Conversion/ShapeToStandard/ShapeToStandardPatterns.td
4

Comment here and below please.

frgossen updated this revision to Diff 271598.Jun 18 2020, 12:51 AM
frgossen marked 2 inline comments as done.

Address comments

This revision was automatically updated to reflect the committed changes.