In this diff llvm-install-name-tool.rst is added and index.rst is
updated.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/docs/CommandGuide/llvm-install-name-tool.rst | ||
---|---|---|
14 | nit: maipulate -> manipulate | |
17 | "it works as a drop-in replacement for Apple's install_name_tool" Is that a common thing for LLVM tools to talk about in descriptions? It seems weird. | |
22 | "some options can be combined with other options". There are only two options here. How about being specific and expanding on this later? | |
28 | Does install-name-tool throw different error codes for different error situations? It might be good to document what those error codes are. |
llvm/docs/CommandGuide/llvm-install-name-tool.rst | ||
---|---|---|
14 | Oops! sorry about that. I'll fix it. | |
17 | So I took inspiration for this from llvm-objcopy's documentation. There is specifies: "The tool is still in active development, but in most scenarios it works as a drop-in replacement for GNU’s objcopy." | |
22 | yup, when I create diffs for -rpath, -id and -change options for install-name, I plan to update this doc as well reflecting the appropriate behavior. | |
28 | it does throw different error "messages" based on different error situations. But i'll take a look if there is a difference in error codes and update it soon. |
llvm/docs/CommandGuide/llvm-install-name-tool.rst | ||
---|---|---|
28 | install-name-tool has exit code 1 for all the errors. I have now updated that in the EXIT STATUS section below. |
LGTM, although it needs to be updated with all the other options now :) (I'm good doing that in a follow-up diff.)
nit: maipulate -> manipulate