- User Since
- Dec 5 2017, 3:14 PM (71 w, 1 d)
Wed, Mar 20
Tue, Mar 19
Mar 11 2019
Mar 9 2019
Mar 6 2019
Feb 26 2019
I agree, simply updating the enum by itself doesn't accomplish much. Is there something specific driving this change?
Feb 22 2019
Built it locally, stepped through the nm code for Mach-O files, didn't see any unintended problems. Elf changes reviewed visually only, they look mechanical. The name for "getNMSectionTagAndName" seems imperfect to me, as the Mach-O symbol type code isn't strictly about the section (A, I, -); that said, sysv is not a common format for viewing Mach-O, so I just offer it as a minor point to consider.
Feb 11 2019
Crud! The wrong code got into this arc request. I'm going to abandon the revision and try again.
... and fix the lit test when always printing the imp pointer.
Always print the imp pointer.
Jan 25 2019
Jan 24 2019
llvm-nm and BinaryFormat changes look good to me.
Jan 20 2019
Jan 15 2019
Jan 13 2019
Fix whitespace indenting for real this time
Fix whitespace indenting
Jan 7 2019
The approach here seems reasonable. I have not tested these changes.
Dec 20 2018
Dec 19 2018
Dec 7 2018
Aug 8 2018
Aug 4 2018
Jul 31 2018
Remove the obsolete "-cfg" option, as called out during review feedback.
The short summary is "-macho" doesn't mean the target file is Mach-O. "-macho" means use the Mach-O specific file parser for walking the file contents, instead of using llvm-Object. When run in this way llvm-objdump will display information in a different way. Like it or hate it, it's what llvm-objdump does currently.
Jul 30 2018
Specify a manpages_url so that CommandGuide references can be used both
as traditional UNIX man-page references and also as nicely hyperlinked
Jan 3 2018
Updating comment based upon review feedback.
Jan 2 2018
Updating change request with review feedback.
Jan 1 2018
Dec 15 2017
Dec 13 2017
Dec 12 2017
Update diff based on feedback from Kevin Enderby: test r_symbolnum for 0