Page MenuHomePhabricator

mtrent (Michael Trent)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 5 2017, 3:14 PM (63 w, 1 d)

Recent Activity

Mon, Feb 11

mtrent abandoned D58058: llvm-objdump -macho -objc-meta-data should print body of protocols in protolist.

Crud! The wrong code got into this arc request. I'm going to abandon the revision and try again.

Mon, Feb 11, 8:45 PM · Restricted Project
mtrent added a comment to D58058: llvm-objdump -macho -objc-meta-data should print body of protocols in protolist.

LGTM.

Looks like we can have print_protocol_list64_t also call the new print_protocol_64_t, but that can be done in a later NFC commit.

Mon, Feb 11, 2:22 PM · Restricted Project
mtrent updated the diff for D58058: llvm-objdump -macho -objc-meta-data should print body of protocols in protolist.

... and fix the lit test when always printing the imp pointer.

Mon, Feb 11, 2:19 PM · Restricted Project
mtrent updated the diff for D58058: llvm-objdump -macho -objc-meta-data should print body of protocols in protolist.

Always print the imp pointer.

Mon, Feb 11, 2:15 PM · Restricted Project
mtrent created D58058: llvm-objdump -macho -objc-meta-data should print body of protocols in protolist.
Mon, Feb 11, 8:52 AM · Restricted Project

Fri, Jan 25

mtrent reopened D57190: [MC] Teach the MachO object writer about N_FUNC_COLD.
Fri, Jan 25, 4:25 PM

Thu, Jan 24

mtrent accepted D57190: [MC] Teach the MachO object writer about N_FUNC_COLD.
Thu, Jan 24, 4:58 PM
mtrent added a comment to D57190: [MC] Teach the MachO object writer about N_FUNC_COLD.

llvm-nm and BinaryFormat changes look good to me.

Thu, Jan 24, 4:58 PM
mtrent committed rL352104: Limit dyld image suffixes guessed by guessLibraryShortName().
Limit dyld image suffixes guessed by guessLibraryShortName()
Thu, Jan 24, 1:00 PM
mtrent closed D56978: Limit dyld image suffixes guessed by guessLibraryShortName().
Thu, Jan 24, 1:00 PM

Jan 20 2019

mtrent created D56978: Limit dyld image suffixes guessed by guessLibraryShortName().
Jan 20 2019, 10:48 AM

Jan 15 2019

mtrent committed rL351238: llvm-objdump -m -D should disassemble all text segments.
llvm-objdump -m -D should disassemble all text segments
Jan 15 2019, 12:45 PM
mtrent closed D56649: llvm-objdump -m -D should disassemble all text segments.
Jan 15 2019, 12:45 PM

Jan 13 2019

mtrent updated the diff for D56649: llvm-objdump -m -D should disassemble all text segments.

Fix whitespace indenting for real this time

Jan 13 2019, 4:15 PM
mtrent updated the diff for D56649: llvm-objdump -m -D should disassemble all text segments.

Fix whitespace indenting

Jan 13 2019, 4:14 PM
mtrent updated the summary of D56649: llvm-objdump -m -D should disassemble all text segments.
Jan 13 2019, 11:24 AM
mtrent created D56649: llvm-objdump -m -D should disassemble all text segments.
Jan 13 2019, 11:23 AM

Jan 7 2019

mtrent accepted D54674: [llvm-objcopy] First bits for MachO .

The approach here seems reasonable. I have not tested these changes.

Jan 7 2019, 7:14 PM · Restricted Project

Dec 20 2018

mtrent committed rL349779: Add PLATFORM constants for iOS, tvOS, and watchOS simulators.
Add PLATFORM constants for iOS, tvOS, and watchOS simulators
Dec 20 2018, 9:54 AM
mtrent closed D55905: Add PLATFORM constants for iOS, tvOS, and watchOS simulators.
Dec 20 2018, 9:54 AM

Dec 19 2018

mtrent created D55905: Add PLATFORM constants for iOS, tvOS, and watchOS simulators.
Dec 19 2018, 3:24 PM

Dec 7 2018

mtrent committed rL348632: Update the Swift version numbers reported by objdump.
Update the Swift version numbers reported by objdump
Dec 7 2018, 11:58 AM
mtrent closed D55442: Update the Swift version numbers reported by objdump.
Dec 7 2018, 11:58 AM
mtrent created D55442: Update the Swift version numbers reported by objdump.
Dec 7 2018, 9:17 AM

Aug 8 2018

mtrent committed rL339250: Add a CommandGuide for llvm-objdump.
Add a CommandGuide for llvm-objdump
Aug 8 2018, 7:39 AM
mtrent closed D50034: Add a CommandGuide for llvm-objdump.
Aug 8 2018, 7:39 AM

Aug 4 2018

mtrent added a comment to D50034: Add a CommandGuide for llvm-objdump.

One last small fix

Aug 4 2018, 7:27 PM

Jul 31 2018

mtrent updated the diff for D50034: Add a CommandGuide for llvm-objdump.

Remove the obsolete "-cfg" option, as called out during review feedback.

Jul 31 2018, 1:12 PM
mtrent added a comment to D50034: Add a CommandGuide for llvm-objdump.

The short summary is "-macho" doesn't mean the target file is Mach-O. "-macho" means use the Mach-O specific file parser for walking the file contents, instead of using llvm-Object. When run in this way llvm-objdump will display information in a different way. Like it or hate it, it's what llvm-objdump does currently.

Jul 31 2018, 1:11 PM

Jul 30 2018

mtrent updated the diff for D50034: Add a CommandGuide for llvm-objdump.

Specify a manpages_url so that CommandGuide references can be used both
as traditional UNIX man-page references and also as nicely hyperlinked
documentation.

Jul 30 2018, 11:54 PM
mtrent added inline comments to D50034: Add a CommandGuide for llvm-objdump.
Jul 30 2018, 11:21 PM
mtrent added inline comments to D50034: Add a CommandGuide for llvm-objdump.
Jul 30 2018, 11:12 PM
mtrent edited reviewers for D50034: Add a CommandGuide for llvm-objdump, added: beanz; removed: enderby.
Jul 30 2018, 11:10 PM
mtrent created D50034: Add a CommandGuide for llvm-objdump.
Jul 30 2018, 6:23 PM

Jan 3 2018

mtrent committed rL321773: Do not look up symbol names when n_strx == 0.
Do not look up symbol names when n_strx == 0
Jan 3 2018, 3:29 PM
mtrent closed D41657: Do not look up symbol names when n_strx == 0.
Jan 3 2018, 3:29 PM
mtrent updated the diff for D41657: Do not look up symbol names when n_strx == 0.

Updating comment based upon review feedback.

Jan 3 2018, 3:11 PM

Jan 2 2018

mtrent updated the diff for D41657: Do not look up symbol names when n_strx == 0.

Updating change request with review feedback.

Jan 2 2018, 1:04 PM
mtrent added a comment to D41657: Do not look up symbol names when n_strx == 0.

I wonder whether you can use something like yaml2obj to craft the object? (or, assuming it's valid, llvm-mc)?
That would improve the readability a lot IMHO.
If not, can you at least add comments to the test (e.g. source file + compiler/linker version etc..) in case we need to regenerate this in the future?

Jan 2 2018, 11:36 AM

Jan 1 2018

mtrent created D41657: Do not look up symbol names when n_strx == 0.
Jan 1 2018, 2:13 PM

Dec 15 2017

mtrent committed rL320832: Updated llvm-objdump to display local relocations in Mach-O binaries.
Updated llvm-objdump to display local relocations in Mach-O binaries
Dec 15 2017, 9:58 AM
mtrent closed D41199: Updated llvm-objdump to display local relocations in Mach-O binaries.
Dec 15 2017, 9:58 AM

Dec 13 2017

mtrent created D41199: Updated llvm-objdump to display local relocations in Mach-O binaries.
Dec 13 2017, 1:29 PM

Dec 12 2017

mtrent committed rL320534: reverting out -r320532 because a warning is breaking the lld build.
reverting out -r320532 because a warning is breaking the lld build
Dec 12 2017, 4:37 PM
mtrent committed rL320532: Updated llvm-objdump to display local relocations in Mach-O binaries.
Updated llvm-objdump to display local relocations in Mach-O binaries
Dec 12 2017, 3:54 PM
mtrent closed D41061: Updated llvm-objdump to display local relocations in Mach-O binaries.
Dec 12 2017, 3:54 PM
mtrent updated the diff for D41061: Updated llvm-objdump to display local relocations in Mach-O binaries.

Update diff based on feedback from Kevin Enderby: test r_symbolnum for 0

Dec 12 2017, 10:07 AM

Dec 10 2017

mtrent created D41061: Updated llvm-objdump to display local relocations in Mach-O binaries.
Dec 10 2017, 9:11 PM

Dec 8 2017

mtrent committed rL320174: Reverting r320166 to fix test failures..
Reverting r320166 to fix test failures.
Dec 8 2017, 11:10 AM
mtrent committed rL320166: Updated llvm-objdump to display local relocations in Mach-O binaries.
Updated llvm-objdump to display local relocations in Mach-O binaries
Dec 8 2017, 9:51 AM
mtrent closed D40867: Updated llvm-objdump to display local relocations in Mach-O binaries.
Dec 8 2017, 9:51 AM

Dec 5 2017

mtrent created D40867: Updated llvm-objdump to display local relocations in Mach-O binaries.
Dec 5 2017, 3:34 PM