This is an archive of the discontinued LLVM Phabricator instance.

[llvm-install-name-tool] Adds docs for install-name-tool
ClosedPublic

Authored by sameerarora101 on Jun 16 2020, 9:17 AM.

Details

Summary

In this diff llvm-install-name-tool.rst is added and index.rst is
updated.

Diff Detail

Event Timeline

sameerarora101 created this revision.Jun 16 2020, 9:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 16 2020, 9:17 AM
Ktwu added inline comments.Jun 16 2020, 10:51 AM
llvm/docs/CommandGuide/llvm-install-name-tool.rst
15

nit: maipulate -> manipulate

18

"it works as a drop-in replacement for Apple's install_name_tool"

Is that a common thing for LLVM tools to talk about in descriptions? It seems weird.

23

"some options can be combined with other options".

There are only two options here. How about being specific and expanding on this later?

29

Does install-name-tool throw different error codes for different error situations? It might be good to document what those error codes are.

sameerarora101 marked 5 inline comments as done.Jun 16 2020, 11:23 AM
sameerarora101 added inline comments.
llvm/docs/CommandGuide/llvm-install-name-tool.rst
15

Oops! sorry about that. I'll fix it.

18

So I took inspiration for this from llvm-objcopy's documentation. There is specifies: "The tool is still in active development, but in most scenarios it works as a drop-in replacement for GNU’s objcopy."

23

yup, when I create diffs for -rpath, -id and -change options for install-name, I plan to update this doc as well reflecting the appropriate behavior.

29

it does throw different error "messages" based on different error situations. But i'll take a look if there is a difference in error codes and update it soon.

sameerarora101 marked an inline comment as done.

Adding exit status and bug report info

sameerarora101 marked 2 inline comments as done.Jun 16 2020, 11:51 AM
sameerarora101 added inline comments.
llvm/docs/CommandGuide/llvm-install-name-tool.rst
29

install-name-tool has exit code 1 for all the errors. I have now updated that in the EXIT STATUS section below.

Updating exit status

This comment was removed by sameerarora101.
Harbormaster completed remote builds in B60523: Diff 271159.
smeenai accepted this revision.Aug 4 2020, 2:28 PM

LGTM, although it needs to be updated with all the other options now :) (I'm good doing that in a follow-up diff.)

This revision is now accepted and ready to land.Aug 4 2020, 2:28 PM