This is an archive of the discontinued LLVM Phabricator instance.

[NewPM][PassInstrumentation] Add PreservedAnalyses parameter to AfterPass* callbacks
ClosedPublic

Authored by yrouban on Jun 10 2020, 5:28 AM.

Details

Summary

Both AfterPass and AfterPassInvalidated pass instrumentation callbacks get additional parameter of type PreservedAnalyses.
This patch was created by @fedor.sergeev. I have just slightly changed it.

Diff Detail

Event Timeline

yrouban created this revision.Jun 10 2020, 5:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2020, 5:28 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
yrouban edited the summary of this revision. (Show Details)Jun 10 2020, 5:51 AM
RKSimon edited reviewers, added: jlebar; removed: RKSimon.Jun 12 2020, 1:56 AM
fedor.sergeev accepted this revision.Jul 20 2020, 2:36 AM

LGTM.
Other people had plenty of time to look at this.

You can proceed with integration.

This revision is now accepted and ready to land.Jul 20 2020, 2:36 AM
yrouban updated this revision to Diff 281470.Jul 28 2020, 10:26 PM

just rebased.

ychen added a subscriber: ychen.Jul 28 2020, 11:05 PM

I would suggest removing 'NFC' from the title.

llvm/lib/IR/PassTimingInfo.cpp
270–272

Remove PA

yrouban retitled this revision from [NewPM][PassInstrumentation] Add PreservedAnalyses parameter to AfterPass* callbacks. NFC to [NewPM][PassInstrumentation] Add PreservedAnalyses parameter to AfterPass* callbacks.Jul 30 2020, 1:59 AM
yrouban updated this revision to Diff 281882.Jul 30 2020, 4:59 AM
yrouban edited the summary of this revision. (Show Details)

rebased + addressed comments (minor)