This is an archive of the discontinued LLVM Phabricator instance.

[ObjectYAML][test] Add test cases for the DWARF64 .debug_addr section.

Authored by Higuoxing on Jun 10 2020, 1:58 AM.



This patch adds test cases for the DWARF64 .debug_addr section.

Diff Detail

Event Timeline

Higuoxing created this revision.Jun 10 2020, 1:58 AM

Is there a reason these can't be part of D81541?

grimar accepted this revision.Jun 10 2020, 2:44 AM

This LGTM. A minor suggestion is inline.


At first I wanted to write that 0xffffffff is not a length, but a special mark, but
DWARF spec says "an initial length field is 12 bytes in size", so this seems fine.
Perhaps I'd mention that 0xffffffff is a special part though.

This revision is now accepted and ready to land.Jun 10 2020, 2:44 AM

Is there a reason these can't be part of D81541?

I'm afraid D81541 is going to be very large and bring difficulty to reviewers. I can merge this patch to that one.

Is there a reason these can't be part of D81541?

+1 to this question. I think there is no reason not to be there.

Higuoxing marked an inline comment as done.Jun 10 2020, 2:49 AM
Higuoxing added inline comments.

I have discussed it with @jhenderson in D81063. Does it make sense here?

Higuoxing abandoned this revision.Jun 10 2020, 2:53 AM

Abandon, merge this to D81542

grimar added inline comments.Jun 10 2020, 3:18 AM

I think it is not harmfull to mention it briefly:

a1) unit_length (DWARF64, 12-byte, starts from 0xffffffff)

I have no strong opinion on this.