Page MenuHomePhabricator
Differential D81498

[Matrix] Preserve volatile when loading loads/stores.
ClosedPublic
Actions

Authored by fhahn on Jun 9 2020, 12:59 PM.

Details

Reviewers
anemet
Gerolf
hfinkel
andrew.w.kaylor
LuoYuanke
nicolasvasilache
Commits
rGd88acd8f7d77: [Matrix] Preserve volatile when loading loads/stores.
Summary

Currently the matrix lowering turns volatile loads/stores into
non-volatile ones. This patch updates the lowering to preserve the
volatile bit.

Diff Detail

Unit TestsFailed
View All

TimeTest
50 mswindows > Clang.SemaObjC::Unknown Unit Message ("")
Script: -- : 'RUN: at line 1'; c:\ws\w6\llvm-project\premerge-checks\build\bin\clang.exe -cc1 -internal-isystem c:\ws\w6\llvm-project\premerge-checks\build\lib\clang\11.0.0\include -nostdsysteminc -fsyntax-only -verify -fenable-matrix C:\ws\w6\llvm-project\premerge-checks\clang\test\SemaObjC\matrix-type-builtins.m

Event Timeline

fhahn created this revision.Jun 9 2020, 12:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 9 2020, 12:59 PM
Herald added subscribers: tschuett, hiraditya. · View Herald Transcript
Harbormaster failed remote builds in B59687: Diff 269640!Jun 9 2020, 1:15 PM
fhahn mentioned this in D81472: [Matrix] Update load/store intrinsics..Jun 10 2020, 8:00 AM
LuoYuanke added inline comments.Jun 13 2020, 10:19 PM
llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
1217–1218

Why we set volatile as false? Is it possible that the original load instruction is volatile load?
Do we allow fusion if the load and store instruction is volatile?

fhahn updated this revision to Diff 270764.Jun 15 2020, 8:31 AM

Pass through volatile flag for matrix fusion, thanks @LuoYuanke!

fhahn marked an inline comment as done.Jun 15 2020, 8:32 AM
fhahn added inline comments.
llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
1217–1218

Yes indeed! I wanted to share the code ASAP, fixed now (with additional test case)

Harbormaster failed remote builds in B60306: Diff 270764!Jun 15 2020, 8:42 AM
anemet accepted this revision.Jun 15 2020, 10:16 AM

LGTM

This revision is now accepted and ready to land.Jun 15 2020, 10:16 AM
fhahn updated this revision to Diff 271119.Jun 16 2020, 9:20 AM

Rebase after cleaning up test diffs.

Harbormaster failed remote builds in B60496: Diff 271119!Jun 16 2020, 9:54 AM
fhahn updated this revision to Diff 271167.Jun 16 2020, 12:27 PM

Rebase after adding another test

Harbormaster failed remote builds in B60528: Diff 271167!Jun 16 2020, 12:41 PM
fhahn updated this revision to Diff 271655.Jun 18 2020, 4:13 AM

Rebased after parent patches landed upstream. Will commit shortly.

Closed by commit rGd88acd8f7d77: [Matrix] Preserve volatile when loading loads/stores. (authored by fhahn). · Explain WhyJun 18 2020, 4:52 AM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B60803: Diff 271655!Jun 18 2020, 5:57 AM

Revision Contents
Changeset List

PathSize
llvm/
lib/
Transforms/
Scalar/
85 lines
test/
Transforms/
LowerMatrixIntrinsics/
10 lines
24 lines
16 lines

Diff 271655

View Options

llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp

Loading...
View Options

llvm/test/Transforms/LowerMatrixIntrinsics/load-align-volatile.ll

Loading...
View Options

llvm/test/Transforms/LowerMatrixIntrinsics/multiply-fused-volatile.ll

Loading...
View Options

llvm/test/Transforms/LowerMatrixIntrinsics/store-align-volatile.ll

Loading...