This is an archive of the discontinued LLVM Phabricator instance.

GlobalISel: Add unit tests for some utils functions
ClosedPublic

Authored by arsenm on Jun 8 2020, 4:44 AM.

Diff Detail

Event Timeline

arsenm created this revision.Jun 8 2020, 4:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2020, 4:44 AM
Herald added subscribers: rovka, mgorny, wdng. · View Herald Transcript
gargaroff accepted this revision.Jun 8 2020, 5:13 AM

LGTM with a nit

llvm/unittests/CodeGen/GlobalISel/GISelUtilsTest.cpp
53

Extra newline?

This revision is now accepted and ready to land.Jun 8 2020, 5:13 AM
arsenm closed this revision.Jun 24 2020, 9:00 AM

4fb2116ee7f19d8048f4d64933b3e8666e3658c2 but had to stop using constexpr