Page MenuHomePhabricator

[MLIR][Shape] Add support for `OpAsmInterface` in `shape.const_size`
ClosedPublic

Authored by frgossen on Jun 5 2020, 3:45 AM.

Details

Summary

The SSA values created with shape.const_size are now named depending on the
value.
A constant size of 3, e.g., is now automatically named %c3.

Depends On D81162

Diff Detail

Event Timeline

frgossen created this revision.Jun 5 2020, 3:45 AM
Herald added a project: Restricted Project. · View Herald Transcript
pifon2a accepted this revision.Jun 5 2020, 5:16 AM
jpienaar accepted this revision.Jun 5 2020, 11:57 AM

Fine with change modulo ShapeOps.td:118 which may just be an old change

This revision is now accepted and ready to land.Jun 5 2020, 11:57 AM
frgossen updated this revision to Diff 269150.Jun 8 2020, 3:25 AM

Move ConstSizeOp::getAsmResultNames

This revision was automatically updated to reflect the committed changes.