This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] Add missing traits and assembly format to `shape.from/to_extent_tensor`
ClosedPublic

Authored by frgossen on Jun 4 2020, 6:35 AM.

Details

Summary

Add NoSideEffect trait to shape.to_extent_tensor and
shape.from_extent_tensor and defined custom assembly format for the
operations.
Infer return type for shape.from_extent_tensor.

Diff Detail

Event Timeline

frgossen created this revision.Jun 4 2020, 6:35 AM
Herald added a reviewer: silvas. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
pifon2a accepted this revision.Jun 4 2020, 6:45 AM
jpienaar added inline comments.Jun 4 2020, 8:09 AM
mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
160

This should no longer be needed

mlir/lib/Dialect/Shape/IR/Shape.cpp
303

Same

339

Same

silvas accepted this revision.Jun 4 2020, 12:38 PM

Looks great! (modulo jacques' comments)

frgossen updated this revision to Diff 269421.Jun 8 2020, 11:58 PM
frgossen marked 3 inline comments as done.

Apply suggestions

silvas accepted this revision.Jun 9 2020, 8:54 AM
jpienaar accepted this revision.Jun 11 2020, 6:26 AM
This revision is now accepted and ready to land.Jun 11 2020, 6:26 AM
This revision was automatically updated to reflect the committed changes.