Ignore MLIRGPUtoCUDATransforms in the MLIRTestTransforms library when the NVPTX target is disabled

[psamolysov]

Summary

When the NVPTX target is enabled, MLIR provides the MLIRGPUtoCUDATransforms conversion library and the MLIRTestTransforms test library as well as the MLIRMlirOptMain one depend on this transform. If a local LLVM build with enabled NVPTX is installed, the information about the libraries and their dependencies is stored into a generated lib\cmake\mlir\MLIRTargets.cmake file.

But when NVPTX is disabled and LLVM is build without NVPTX (only with X86 for example), the MLIRGPUtoCUDATransforms conversion library is not created and there is no information about the library in the generated lib\cmake\mlir\MLIRTargets.cmake file. Regardless this fact, the MLIRTestTransforms still depends on the conversion library and the MLIRTargets.cmake file contains the following line:

set_target_properties(MLIRTestTransforms PROPERTIES
  INTERFACE_LINK_LIBRARIES "MLIRAffineOps;MLIRAnalysis;MLIREDSC;MLIRGPU;MLIRGPUtoCUDATransforms;...
)

The patch wraps MLIRGPUtoCUDATransforms into a condition: MLIRTestTransforms depends on the library iff MLIR_CUDA_CONVERSIONS_ENABLED is true.

[psamolysov]

I believe this fail is not related to MLIR

[ftynse]

This pass was refactored in D80142, could you please update this accordingly?

[psamolysov]

@ftynse Thank you for your comment. As I see, ROCM and CUDA support has been merged into the MLIRGPUtoGPURuntimeTransforms library and when I have neither CUDA nor AMDGPU, the library still be built but without being linked with the CUDA and/or AMDGPU targets. So, I see I'm a bit late and my patch is not required :)

[ftynse]

Thanks anyway!

mlir/test/lib/Transforms/CMakeLists.txt

 # Exclude tests from libMLIR.so
+if (MLIR_CUDA_CONVERSIONS_ENABLED)
+  set(GPU_TO_CUDA_LIB "MLIRGPUtoCUDATransforms")
+else()
+  set(GPU_TO_CUDA_LIB "")
+endif()
+
 add_mlir_library(MLIRTestTransforms
   TestAllReduceLowering.cpp
   TestBufferPlacement.cpp
   TestCallGraph.cpp
   TestConstantFold.cpp
   TestConvertGPUKernelToCubin.cpp
   TestDominance.cpp
   TestLoopFusion.cpp
add_mlir_library(MLIRTestTransforms
   MLIRStandardOpsIncGen
   MLIRTestVectorTransformPatternsIncGen
 
   LINK_LIBS PUBLIC
   MLIRAffineOps
   MLIRAnalysis
   MLIREDSC
   MLIRGPU
-  MLIRGPUtoCUDATransforms
+  ${GPU_TO_CUDA_LIB}
   MLIRLinalgOps
   MLIRLinalgTransforms
   MLIRSCF
   MLIRGPU
   MLIRPass
   MLIRStandardOpsTransforms
   MLIRTestDialect
   MLIRTransformUtils
   MLIRVectorToSCF
   MLIRVector
   )
 
 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../Dialect/Test)
 include_directories(${CMAKE_CURRENT_BINARY_DIR}/../Dialect/Test)
 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../DeclarativeTransforms)
 include_directories(${CMAKE_CURRENT_BINARY_DIR}/../DeclarativeTransforms)