Page MenuHomePhabricator

[mlir][shape] Use IndexElementsAttr in Shape dialect.
ClosedPublic

Authored by silvas on May 26 2020, 4:59 PM.

Details

Summary

Index is the proper type for storing shapes when constant folding, so
this fixes the previous code (which was using i64).

Diff Detail

Event Timeline

silvas created this revision.May 26 2020, 4:59 PM
Herald added a project: Restricted Project. · View Herald Transcript
herhut accepted this revision.May 27 2020, 2:52 AM

Much nicer indeed!

jpienaar accepted this revision.May 27 2020, 7:16 AM

Thanks, good cleanup

This revision is now accepted and ready to land.May 27 2020, 7:16 AM
This revision was automatically updated to reflect the committed changes.