Page MenuHomePhabricator

[NFCI][CostModel] Unify getCmpSelInstrCost
ClosedPublic

Authored by samparker on May 26 2020, 5:56 AM.

Details

Summary

Add cases for icmp, fcmp and select into the switch statement of the generic getUserCost implementation with getInstructionThroughput then calling into it. The BasicTTI and backend implementations have be set to return a default value (1) when a cost other than throughput is being queried.

Diff Detail

Event Timeline

samparker created this revision.May 26 2020, 5:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2020, 5:56 AM
samparker updated this revision to Diff 266196.May 26 2020, 6:30 AM

Added missed AArch64 change.

spatel accepted this revision.Jun 5 2020, 9:41 AM

LGTM

This revision is now accepted and ready to land.Jun 5 2020, 9:41 AM
This revision was automatically updated to reflect the committed changes.