This is an archive of the discontinued LLVM Phabricator instance.

[NFC][PowerPC] Remove the redundant InstAlias for OR instruction
ClosedPublic

Authored by ZhangKang on May 24 2020, 6:38 PM.

Details

Summary

We have handle the InstAlias for OR instructions, but we handle it agagin in PPCInstPrinter.cpp.
We can add some InstAlias in PPCInstPrinter.cpp when we can't handle it in td files. But it's obvious that we can handle or
in td files and we have done it.

PPCInstr64Bit.td:930:def : InstAlias<"mr $rA, $rB", (OR8 g8rc:$rA, g8rc:$rB, g8rc:$rB)>;
PPCInstr64Bit.td:931:def : InstAlias<"mr. $rA, $rB", (OR8_rec g8rc:$rA, g8rc:$rB, g8rc:$rB)>;
PPCInstrInfo.td:2488:def : InstAlias<"mr $rA, $rB", (OR gprc:$rA, gprc:$rB, gprc:$rB)>;
PPCInstrInfo.td:2489:def : InstAlias<"mr. $rA, $rB", (OR_rec gprc:$rA, gprc:$rB, gprc:$rB)>;

We should remove the redundant for OR in PPCInstPrinter.cpp.

Diff Detail

Event Timeline

ZhangKang created this revision.May 24 2020, 6:38 PM
This revision is now accepted and ready to land.Jun 8 2020, 6:48 PM
This revision was automatically updated to reflect the committed changes.