This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Select strict_fadd
ClosedPublic

Authored by arsenm on May 23 2020, 7:48 AM.

Details

Summary

This isn't 100% correct without properly setting hasFPExceptions on
the machine instsruction

Diff Detail

Event Timeline

arsenm created this revision.May 23 2020, 7:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2020, 7:48 AM

Are you planning to address the correctness issue here with a follow-up? I cannot say I am thrilled to lower something incorrectly even temporarily.

Are you planning to address the correctness issue here with a follow-up? I cannot say I am thrilled to lower something incorrectly even temporarily.

Yes. You can't get very far trying to actually use these yet (plus they have experimental in the name for a reason)

rampitec accepted this revision.May 26 2020, 10:56 AM

Are you planning to address the correctness issue here with a follow-up? I cannot say I am thrilled to lower something incorrectly even temporarily.

Yes. You can't get very far trying to actually use these yet (plus they have experimental in the name for a reason)

OK, just please update it soon.

This revision is now accepted and ready to land.May 26 2020, 10:56 AM