This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Start adding MODE register uses to instructions
ClosedPublic

Authored by arsenm on May 23 2020, 7:47 AM.

Details

Summary

This is the groundwork required to implement strictfp. For now, this
should be NFC for regular instructions (many instructions just gain an
extra use of a reserved register). Regalloc won't rematerialize
instructions with reads of physical registers, but we were suffering
from that anyway with the exec reads.

Should add it for all the related FP uses (possibly with some
extras). I did not add it to either the gpr index mode instructions
or every single VALU instruction) since it's a ridiculous feature
already modeled as an arbitrary side effect.

Also work towards marking instructions with FP exceptions. This
doesn't actually set the bit yet since this would start to change
codegen. It seems nofpexcept is currently not implied from the regular
IR FP operations. Add it to some MIR tests where I think it might
matter.

Diff Detail

Event Timeline

arsenm created this revision.May 23 2020, 7:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2020, 7:47 AM
arsenm updated this revision to Diff 266514.May 27 2020, 6:25 AM

Add to interp instructions

This revision is now accepted and ready to land.May 27 2020, 9:50 AM