Page MenuHomePhabricator

[mlir] Add custom assembly formats to shape.witness ops.
ClosedPublic

Authored by tpopp on Mon, May 18, 9:33 PM.

Details

Summary

The assembly formats are essentially the generic forms without
quotations and type information.

Diff Detail

Event Timeline

tpopp created this revision.Mon, May 18, 9:33 PM
Herald added a reviewer: silvas. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
herhut accepted this revision.Tue, May 19, 2:02 AM

Reads much nicer!

silvas requested changes to this revision.Tue, May 19, 9:50 AM
silvas added inline comments.
mlir/test/Dialect/Shape/ops.mlir
74–76

can we remove the parentheses? It's easier to type and read IMO and is consistent with many std and other ops (like addi)

This revision now requires changes to proceed.Tue, May 19, 9:50 AM
tpopp updated this revision to Diff 265168.Wed, May 20, 2:02 AM

Remove parantheses

tpopp updated this revision to Diff 265188.Wed, May 20, 2:48 AM

Match example code in documentation to the actual custom form.

tpopp marked an inline comment as done.Wed, May 20, 4:14 AM
tpopp added a comment.Wed, May 20, 4:21 AM

@silvas I was going to wait because you hadn't accepted the commit, but because (1) I am not working the next 4 days and (2) have other commits using these operations, I'm going to submit this, but can follow up on any other feedback.

This revision was not accepted when it landed; it landed in state Needs Review.Wed, May 20, 4:51 AM
Closed by commit rG02035580d3b5: [mlir] Add custom assembly formats to shape.witness ops. (authored by Tres Popp <tpopp@google.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.