This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
llvm/docs/
-
docs/
1/5
Phabricator.rst

Differential D79964

Update 'git push' command in GettingStarted guide
ClosedPublic

Authored by dcaballe on May 14 2020, 1:42 PM.

Download Raw Diff

Details

Reviewers

jyknight
jlebar
mehdi_amini

Commits

rGb78b98491ada: Update 'git push' command in GettingStarted guide

Summary

'git push' command, without any other arguments, can do different
things depending on the local configuration of Git. However, it
won't push your local 'arcpatch-D<Revision>' to the remote 'master'
branch by default. This patch updates the 'git push' command with
the extra arguments needed to commit 'arcpatch-D<Revision>' to the
remote 'master' branch.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	130 ms	Clang.CodeGen::Unknown Unit Message ("")
	120 ms	Clang.CodeGen::Unknown Unit Message ("")
	110 ms	Clang.CodeGenCXX::Unknown Unit Message ("")
	150 ms	Clang.CodeGenCXX::Unknown Unit Message ("")
	120 ms	Clang.CodeGenCXX::Unknown Unit Message ("")
		View Full Test Results (49 Failed)

Event Timeline

dcaballe created this revision.May 14 2020, 1:42 PM

Herald added a project: Restricted Project. · View Herald TranscriptMay 14 2020, 1:42 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Harbormaster failed remote builds in B56782: Diff 264085!May 14 2020, 3:15 PM

mehdi_amini added inline comments.May 14 2020, 9:21 PM

llvm/docs/Phabricator.rst
218	The generic way of pushing would rather be I believe: `git push origin HEAD:master` what about using this instead? It is closer to ensuring you're pushing what you just tested (we should like tell folks to check that their local state is clean as well) (note that origin is read-only locally for me, but I assume that for such doc we can assume a "default" setup)

echristo added a subscriber: echristo.May 14 2020, 10:14 PM

echristo added inline comments.

llvm/docs/Phabricator.rst
218	+1

dcaballe marked an inline comment as done.May 14 2020, 10:52 PM

dcaballe added inline comments.

llvm/docs/Phabricator.rst
218	It sounds good! I'll give it a try in my next commit and change it. Thanks!

Changing to git push origin HEAD:master

tstellar added a subscriber: tstellar.May 19 2020, 6:18 PM

tstellar added inline comments.

llvm/docs/Phabricator.rst
218	I would even take this a step further and replace origin with the full repo name e.g. git push https://github.com/llvm/llvm-project.git HEAD:master I think the documentation should give instructions that are guaranteed to work regardless of the user's configuration.

Harbormaster completed remote builds in B57310: Diff 265104.May 19 2020, 7:49 PM

It sounds good, thanks.
Replacing 'origin' with 'https://github.com/llvm/llvm-project.git' in git pull and push commands.

Harbormaster completed remote builds in B57406: Diff 265288.May 20 2020, 11:27 AM

Ping :)

I'm still ok with this :)

LGTM

llvm/docs/Phabricator.rst
218	I think the documentation should give instructions that are guaranteed to work regardless of the user's configuration. Documentation for developer can be skewed towards providing instruction in a usable form: I'm not gonna type the complete URL!

This revision is now accepted and ready to land.May 29 2020, 5:47 PM

Closed by commit rGb78b98491ada: Update 'git push' command in GettingStarted guide (authored by dcaballe). · Explain WhyJun 2 2020, 11:32 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

docs/

Phabricator.rst

2 lines

Diff 264085

llvm/docs/Phabricator.rst

	Show First 20 Lines • Show All 209 Lines • ▼ Show 20 Lines
	Then, make sure the commit is up-to-date, and commit it. This can be done by running			Then, make sure the commit is up-to-date, and commit it. This can be done by running
	the following:			the following:

	::			::

	git pull --rebase origin master			git pull --rebase origin master
	git show # Ensure the patch looks correct.			git show # Ensure the patch looks correct.
	ninja check-$whatever # Rerun the appropriate tests if needed.			ninja check-$whatever # Rerun the appropriate tests if needed.
	git push			git push origin arcpatch-D<Revision>:master
				mehdi_aminiUnsubmitted Not Done Reply Inline Actions The generic way of pushing would rather be I believe: `git push origin HEAD:master` what about using this instead? It is closer to ensuring you're pushing what you just tested (we should like tell folks to check that their local state is clean as well) (note that origin is read-only locally for me, but I assume that for such doc we can assume a "default" setup) mehdi_amini: The generic way of pushing would rather be I believe: `git push origin HEAD:master` what about…
				echristoUnsubmitted Not Done Reply Inline Actions +1 echristo: +1
				dcaballeAuthorUnsubmitted Done Reply Inline Actions It sounds good! I'll give it a try in my next commit and change it. Thanks! dcaballe: It sounds good! I'll give it a try in my next commit and change it. Thanks!
				tstellarUnsubmitted Not Done Reply Inline Actions I would even take this a step further and replace origin with the full repo name e.g. git push https://github.com/llvm/llvm-project.git HEAD:master I think the documentation should give instructions that are guaranteed to work regardless of the user's configuration. tstellar: I would even take this a step further and replace origin with the full repo name e.g. git push…
				mehdi_aminiUnsubmitted Not Done Reply Inline Actions I think the documentation should give instructions that are guaranteed to work regardless of the user's configuration. Documentation for developer can be skewed towards providing instruction in a usable form: I'm not gonna type the complete URL! mehdi_amini: > I think the documentation should give instructions that are guaranteed to work regardless of…

	Or			Or

	::			::

	arc land D<Revision>			arc land D<Revision>


	Show All 30 Lines