This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] Enable machine verification for 3 passes
ClosedPublic

Authored by ZhangKang on May 12 2020, 11:49 PM.

Details

Summary

For PowerPC, there are 3 passes has disabled the machine verification.

PPCTargetMachine.cpp:    addPass(&LiveVariablesID, false);
PPCTargetMachine.cpp:    addPass(createPPCEarlyReturnPass(), false);
PPCTargetMachine.cpp:  addPass(createPPCBranchSelectionPass(), false);

Three are 3 patches to fix the machine verification for PowerPC.
https://github.com/llvm/llvm-project/commit/782a4dd1a478e41857744b483b104b5e66857fbf is to fix the operand flag for ppc-early-ret pass.
https://github.com/llvm/llvm-project/commit/4bb0a1cb70732f16749df6d47fd85eb86d60f587 is to fix the liveness for ppc-expand-isel pass.
https://github.com/llvm/llvm-project/commit/302e11cd974255eafd80ee4fdf52054a00b3e4be is to fix 3 cases issues.

After upstream above 3 patches, all PowerPC pass can enable machine verification and all cases can be passes(enable EXPENSIVE_CHECKS).

This patch is to enable machine verification for above three passes.

Diff Detail

Event Timeline

ZhangKang created this revision.May 12 2020, 11:49 PM
ZhangKang edited the summary of this revision. (Show Details)May 12 2020, 11:53 PM
steven.zhang accepted this revision.May 18 2020, 12:32 AM

LGTM, thank you for enabling this.

This revision is now accepted and ready to land.May 18 2020, 12:32 AM
This revision was automatically updated to reflect the committed changes.