[MSan] Pass MSan command line options under new pass manager

[aeubanks]

Summary

Properly forward TrackOrigins and Recover user options to the MSan pass under the new pass manager.
This makes the number of check-msan failures when ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER is TRUE go from 52 to 2.

Based on https://reviews.llvm.org/D77249.

[leonardchan]

In addSanitizersAtO0, could you make something similar to the ASanPass lambda for the MSan passes and also apply it when adding kernel MSan?

[aeubanks]

Address review comments

[aeubanks]

In D79445#2021311, @leonardchan wrote:

In addSanitizersAtO0, could you make something similar to the ASanPass lambda for the MSan passes and also apply it when adding kernel MSan?

It ends up calling an extra MPM.addPass(createModuleToFunctionPassAdaptor()) in the KernelMemory case, is that okay?

[vitalybuka]

In D79445#2021502, @aeubanks wrote:

In D79445#2021311, @leonardchan wrote:

In addSanitizersAtO0, could you make something similar to the ASanPass lambda for the MSan passes and also apply it when adding kernel MSan?

It ends up calling an extra MPM.addPass(createModuleToFunctionPassAdaptor()) in the KernelMemory case, is that okay?

Not sure about that.

[leonardchan]

In D79445#2021502, @aeubanks wrote:

In D79445#2021311, @leonardchan wrote:

In addSanitizersAtO0, could you make something similar to the ASanPass lambda for the MSan passes and also apply it when adding kernel MSan?

It ends up calling an extra MPM.addPass(createModuleToFunctionPassAdaptor()) in the KernelMemory case, is that okay?

Didn't notice that at first. What you originally had seems ok then if there wasn't already a module adaptor for the pass;

[aeubanks]

Revert back to initial patch

clang/lib/CodeGen/BackendUtil.cpp

if (LangOpts.Sanitize.has(SanitizerKind::Address)) {
     ASanPass(SanitizerKind::Address, /*CompileKernel=*/false);
   }
 
   if (LangOpts.Sanitize.has(SanitizerKind::KernelAddress)) {
     ASanPass(SanitizerKind::KernelAddress, /*CompileKernel=*/true);
   }
 
   if (LangOpts.Sanitize.has(SanitizerKind::Memory)) {
-    MPM.addPass(MemorySanitizerPass({}));
-    MPM.addPass(createModuleToFunctionPassAdaptor(MemorySanitizerPass({})));
+    bool Recover = CodeGenOpts.SanitizeRecover.has(SanitizerKind::Memory);
+    int TrackOrigins = CodeGenOpts.SanitizeMemoryTrackOrigins;
+    MPM.addPass(MemorySanitizerPass({TrackOrigins, Recover, false}));
+    MPM.addPass(createModuleToFunctionPassAdaptor(
+        MemorySanitizerPass({TrackOrigins, Recover, false})));
   }
 
   if (LangOpts.Sanitize.has(SanitizerKind::KernelMemory)) {
     MPM.addPass(createModuleToFunctionPassAdaptor(
         MemorySanitizerPass({0, false, /*Kernel=*/true})));
   }
 
   if (LangOpts.Sanitize.has(SanitizerKind::Thread)) {
if (CodeGenOpts.OptimizationLevel == 0) {
       // the pipeline.
       // FIXME: either handle asan/the remaining sanitizers or error out
       if (LangOpts.Sanitize.has(SanitizerKind::LocalBounds))
         PB.registerScalarOptimizerLateEPCallback(
             [](FunctionPassManager &FPM, PassBuilder::OptimizationLevel Level) {
               FPM.addPass(BoundsCheckingPass());
             });
       if (LangOpts.Sanitize.has(SanitizerKind::Memory)) {
-        PB.registerPipelineStartEPCallback([](ModulePassManager &MPM) {
-          MPM.addPass(MemorySanitizerPass({}));
+        int TrackOrigins = CodeGenOpts.SanitizeMemoryTrackOrigins;
+        bool Recover = CodeGenOpts.SanitizeRecover.has(SanitizerKind::Memory);
+        PB.registerPipelineStartEPCallback(
+            [TrackOrigins, Recover](ModulePassManager &MPM) {
+              MPM.addPass(MemorySanitizerPass({TrackOrigins, Recover, false}));
             });
         PB.registerOptimizerLastEPCallback(
-            [](FunctionPassManager &FPM, PassBuilder::OptimizationLevel Level) {
-              FPM.addPass(MemorySanitizerPass({}));
+            [TrackOrigins, Recover](FunctionPassManager &FPM,
+                                    PassBuilder::OptimizationLevel Level) {
+              FPM.addPass(MemorySanitizerPass({TrackOrigins, Recover, false}));
             });
       }
       if (LangOpts.Sanitize.has(SanitizerKind::Thread)) {
         PB.registerPipelineStartEPCallback(
             [](ModulePassManager &MPM) { MPM.addPass(ThreadSanitizerPass()); });
         PB.registerOptimizerLastEPCallback(
             [](FunctionPassManager &FPM, PassBuilder::OptimizationLevel Level) {
               FPM.addPass(ThreadSanitizerPass());