Page MenuHomePhabricator
Differential D79332

[MLIR] Nested regions test for Buffer Assginment
ClosedPublic
Actions

Authored by dfki-ehna on May 4 2020, 8:12 AM.

Details

Reviewers
mehdi_amini
herhut
pifon2a
Commits
rG1b140a87a581: [MLIR] Nested regions test for Buffer Assginment
Summary

Due to the extension of Liveness, Buffer Assignment can now work on nested regions. This PR provides a test case to show that existing functionally of BA works properly.

Diff Detail

Event Timeline

dfki-ehna created this revision.May 4 2020, 8:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2020, 8:12 AM
Herald added subscribers: llvm-commits, Kayjukh, frgossen and 12 others. · View Herald Transcript
Harbormaster completed remote builds in B55640: Diff 261828.May 4 2020, 9:38 AM
mehdi_amini added inline comments.May 4 2020, 10:21 AM
mlir/test/Transforms/buffer-placement.mlir
416

Can you expand the doc on what this test is doing? Either here or in line with the checks themselves.

452

Nit: can you indent it to represent the expected nesting? It'll make it more readable.

dfki-ehna updated this revision to Diff 262091.May 5 2020, 6:12 AM

Add description and indent.

dfki-ehna marked 2 inline comments as done.May 5 2020, 6:49 AM
dfki-ehna added reviewers: mehdi_amini, herhut, pifon2a.
dfki-ehna added a project: Restricted Project.
Harbormaster failed remote builds in B55781: Diff 262091!May 5 2020, 7:31 AM
herhut accepted this revision.May 7 2020, 5:14 AM

Thanks, I am happy to see this land. Just some nits.

mlir/test/Transforms/buffer-placement.mlir
416

Could you reflow the comment to match 80 chars?

455

Could you add where the BB3 starts? That makes it easier to understand what is going on here.

This revision is now accepted and ready to land.May 7 2020, 5:14 AM
Herald added a subscriber: stephenneuendorffer. · View Herald TranscriptMay 7 2020, 5:14 AM
dfki-ehna marked 2 inline comments as done.May 13 2020, 6:03 AM
Closed by commit rG1b140a87a581: [MLIR] Nested regions test for Buffer Assginment (authored by dfki-ehna). · Explain WhyMay 13 2020, 6:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
mlir/
test/
Transforms/
49 lines

Diff 263691

View Options

mlir/test/Transforms/buffer-placement.mlir

Loading...