[MLIR] Nested regions test for Buffer Assginment
ClosedPublic
Actions

Authored by dfki-ehna on Mon, May 4, 8:12 AM.

Details

Reviewers

mehdi_amini
herhut
pifon2a

Commits

rG1b140a87a581: [MLIR] Nested regions test for Buffer Assginment

Summary

Due to the extension of Liveness, Buffer Assignment can now work on nested regions. This PR provides a test case to show that existing functionally of BA works properly.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

dfki-ehna created this revision.Mon, May 4, 8:12 AM

Herald added a project: Restricted Project. · View Herald TranscriptMon, May 4, 8:12 AM

Herald added subscribers: llvm-commits, Kayjukh, frgossen and 12 others. · View Herald Transcript

Harbormaster completed remote builds in B55640: Diff 261828.Mon, May 4, 9:38 AM

mehdi_amini added inline comments.Mon, May 4, 10:21 AM

mlir/test/Transforms/buffer-placement.mlir
416	Can you expand the doc on what this test is doing? Either here or in line with the checks themselves.
452	Nit: can you indent it to represent the expected nesting? It'll make it more readable.

Add description and indent.

dfki-ehna marked 2 inline comments as done.Tue, May 5, 6:49 AM

dfki-ehna added reviewers: mehdi_amini, herhut, pifon2a.

dfki-ehna added a project: Restricted Project.

Harbormaster failed remote builds in B55781: Diff 262091!Tue, May 5, 7:31 AM

Thanks, I am happy to see this land. Just some nits.

mlir/test/Transforms/buffer-placement.mlir
416	Could you reflow the comment to match 80 chars?
455	Could you add where the BB3 starts? That makes it easier to understand what is going on here.

This revision is now accepted and ready to land.Thu, May 7, 5:14 AM

Herald added a subscriber: stephenneuendorffer. · View Herald TranscriptThu, May 7, 5:14 AM

dfki-ehna marked 2 inline comments as done.Wed, May 13, 6:03 AM

Closed by commit rG1b140a87a581: [MLIR] Nested regions test for Buffer Assginment (authored by dfki-ehna). · Explain WhyWed, May 13, 6:27 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			mlir/test/Transforms/buffer-placement.mlir (49 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	261828	231026a		Mon, May 4, 8:12 AM	★	★
Diff 2	262091	13090ec	Add description and indent.	Tue, May 5, 6:12 AM	★	★
Diff 3	263691	410644f	rG1b140a87a5815513da69fa894e9533f500ea1c12	Wed, May 13, 5:53 AM	★	★

Diff 263691

View Options

mlir/test/Transforms/buffer-placement.mlir

[MLIR] Nested regions test for Buffer AssginmentClosedPublicActions