Page MenuHomePhabricator

[MLIR] Nested regions test for Buffer Assginment
ClosedPublic

Authored by dfki-ehna on Mon, May 4, 8:12 AM.

Details

Summary

Due to the extension of Liveness, Buffer Assignment can now work on nested regions. This PR provides a test case to show that existing functionally of BA works properly.

Diff Detail

Event Timeline

dfki-ehna created this revision.Mon, May 4, 8:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptMon, May 4, 8:12 AM
mehdi_amini added inline comments.Mon, May 4, 10:21 AM
mlir/test/Transforms/buffer-placement.mlir
416

Can you expand the doc on what this test is doing? Either here or in line with the checks themselves.

452

Nit: can you indent it to represent the expected nesting? It'll make it more readable.

dfki-ehna updated this revision to Diff 262091.Tue, May 5, 6:12 AM

Add description and indent.

dfki-ehna marked 2 inline comments as done.Tue, May 5, 6:49 AM
dfki-ehna added reviewers: mehdi_amini, herhut, pifon2a.
dfki-ehna added a project: Restricted Project.
herhut accepted this revision.Thu, May 7, 5:14 AM

Thanks, I am happy to see this land. Just some nits.

mlir/test/Transforms/buffer-placement.mlir
416

Could you reflow the comment to match 80 chars?

455

Could you add where the BB3 starts? That makes it easier to understand what is going on here.

This revision is now accepted and ready to land.Thu, May 7, 5:14 AM
dfki-ehna marked 2 inline comments as done.Wed, May 13, 6:03 AM
This revision was automatically updated to reflect the committed changes.