Page MenuHomePhabricator

dfki-ehna (Ehsan)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 20 2020, 3:53 AM (15 w, 4 d)

Recent Activity

Mon, Aug 3

dfki-ehna updated the summary of D85133: [mlir] Extend BufferAssignmentTypeConverter with result conversion callbacks.
Mon, Aug 3, 7:07 AM · Restricted Project
dfki-ehna requested review of D85133: [mlir] Extend BufferAssignmentTypeConverter with result conversion callbacks.
Mon, Aug 3, 7:04 AM · Restricted Project

Mon, Jul 27

dfki-ehna committed rG486d2750c715: [mlir][NFC] Polish copy removal transform (authored by dfki-ehna).
[mlir][NFC] Polish copy removal transform
Mon, Jul 27, 11:37 PM
dfki-ehna closed D84529: [mlir][NFC] Polish copy removal transform.
Mon, Jul 27, 11:36 PM · Restricted Project
dfki-ehna retitled D84529: [mlir][NFC] Polish copy removal transform from [mlir] Polish copy removal transform to [mlir][NFC] Polish copy removal transform.
Mon, Jul 27, 11:32 PM · Restricted Project
dfki-ehna updated the diff for D84529: [mlir][NFC] Polish copy removal transform.

Address the comments.

Mon, Jul 27, 11:28 PM · Restricted Project

Fri, Jul 24

dfki-ehna added reviewers for D84529: [mlir][NFC] Polish copy removal transform: rriddle, herhut, pifon2a.
Fri, Jul 24, 6:48 AM · Restricted Project
Herald added a project to D84529: [mlir][NFC] Polish copy removal transform: Restricted Project.
Fri, Jul 24, 6:48 AM · Restricted Project

Wed, Jul 22

dfki-ehna added a comment to D82757: [mlir] Add redundant copy removal transform.

@rriddle Thanks for the comments. They will be fixed in the upcoming PR for the copy removal.

Wed, Jul 22, 12:11 AM · Restricted Project

Tue, Jul 21

dfki-ehna added a comment to D83799: [MLIR] Support function signature conversions with tuples of results types.

@bondhugula Yes, I am working on it.
@rriddle @mehdi_amini We have started to provide a detailed document for BA.

Tue, Jul 21, 12:45 AM · Restricted Project

Jul 3 2020

dfki-ehna committed rG0f03b2bfda97: [mlir] Add redundant copy removal transform (authored by dfki-ehna).
[mlir] Add redundant copy removal transform
Jul 3 2020, 6:58 AM
dfki-ehna closed D82757: [mlir] Add redundant copy removal transform.
Jul 3 2020, 6:58 AM · Restricted Project
dfki-ehna retitled D82757: [mlir] Add redundant copy removal transform from [mlir]Add redundant copy removal transform to [mlir] Add redundant copy removal transform.
Jul 3 2020, 4:49 AM · Restricted Project
dfki-ehna retitled D82757: [mlir] Add redundant copy removal transform from [mlir][linalg] Add redundant copy removal transform to [mlir]Add redundant copy removal transform.
Jul 3 2020, 4:49 AM · Restricted Project
dfki-ehna updated the diff for D82757: [mlir] Add redundant copy removal transform.

The following points are addressed:

  • The remaining comments are resolved.
  • CopyOpInterface is introduced and added to linalg.copy.
  • Make this pass generic for all copies.
  • The pass is moved to mlir/lib/transforms.
  • copy-removal.mlir is moved to mlir/test/transforms.
Jul 3 2020, 4:49 AM · Restricted Project

Jul 1 2020

dfki-ehna updated the diff for D82757: [mlir] Add redundant copy removal transform.

Add another copy removal condition and a few more test cases.

Jul 1 2020, 8:05 AM · Restricted Project
dfki-ehna updated the diff for D82757: [mlir] Add redundant copy removal transform.

Address the multiple deallocation issue.

Jul 1 2020, 1:35 AM · Restricted Project
dfki-ehna added inline comments to D82757: [mlir] Add redundant copy removal transform.
Jul 1 2020, 1:35 AM · Restricted Project

Jun 30 2020

dfki-ehna added a comment to D82757: [mlir] Add redundant copy removal transform.

@mehdi_amini Is there any generic copy interface available? The other problem would be in test files that how we can specify the copy operation class for the pass. @herhut suggested that since it is going to be a dialect independent and unique copy at the end, we can start with linalg.copy and generalize it later on.
In summary, what we'd like to achieve is to remove %to value and the Copy operation, and replace all its uses with %from value. In both of these examples, if we remove %to and the copy operation, and replace it with %from, the logic of the program will change.

Jun 30 2020, 7:34 AM · Restricted Project
dfki-ehna updated the diff for D82757: [mlir] Add redundant copy removal transform.

Comments are addressed.

Jun 30 2020, 7:33 AM · Restricted Project

Jun 29 2020

dfki-ehna added reviewers for D82757: [mlir] Add redundant copy removal transform: herhut, pifon2a.
Jun 29 2020, 4:17 AM · Restricted Project
dfki-ehna created D82757: [mlir] Add redundant copy removal transform.
Jun 29 2020, 4:17 AM · Restricted Project

Jun 8 2020

dfki-ehna committed rG4214031d4337: [mlir] Introduce allowMemrefFunctionResults for the helper operation converters… (authored by dfki-ehna).
[mlir] Introduce allowMemrefFunctionResults for the helper operation converters…
Jun 8 2020, 1:03 AM
dfki-ehna closed D81137: [mlir] Introduce allowMemrefFunctionResults for the helper operation converters of buffer placement.
Jun 8 2020, 1:03 AM · Restricted Project

Jun 5 2020

dfki-ehna added a comment to D81137: [mlir] Introduce allowMemrefFunctionResults for the helper operation converters of buffer placement.

Thanks for suggesting to use the Pass option. I made TestBufferPlacementPreparationPass a template struct due to the fact that registerTestBufferPlacementPreparationPass and registerTestPreparationPassWithAllowedMemrefResults are two passes for only test purposes which shouldn't be publicly seen.

Jun 5 2020, 5:27 AM · Restricted Project
dfki-ehna updated the diff for D81137: [mlir] Introduce allowMemrefFunctionResults for the helper operation converters of buffer placement.

Correct the position of registerTestPreparationPassWithAllowedMemrefResults.

Jun 5 2020, 5:27 AM · Restricted Project
dfki-ehna updated the diff for D81137: [mlir] Introduce allowMemrefFunctionResults for the helper operation converters of buffer placement.

Address the comments.

Jun 5 2020, 5:27 AM · Restricted Project

Jun 4 2020

dfki-ehna updated the summary of D81137: [mlir] Introduce allowMemrefFunctionResults for the helper operation converters of buffer placement.
Jun 4 2020, 3:45 AM · Restricted Project
dfki-ehna created D81137: [mlir] Introduce allowMemrefFunctionResults for the helper operation converters of buffer placement.
Jun 4 2020, 3:45 AM · Restricted Project

Jun 2 2020

dfki-ehna committed rG3f6a35e3ffd4: [mlir] Introduce CallOp converter for buffer placement (authored by dfki-ehna).
[mlir] Introduce CallOp converter for buffer placement
Jun 2 2020, 2:46 AM
dfki-ehna closed D80785: [MLIR][BUFFER_PLACEMENT] Introduce CallOp converter for buffer placement.
Jun 2 2020, 2:46 AM · Restricted Project, Restricted Project
dfki-ehna updated the diff for D80785: [MLIR][BUFFER_PLACEMENT] Introduce CallOp converter for buffer placement.

Resolve the comments.

Jun 2 2020, 2:45 AM · Restricted Project, Restricted Project

May 29 2020

dfki-ehna added reviewers for D80785: [MLIR][BUFFER_PLACEMENT] Introduce CallOp converter for buffer placement: herhut, pifon2a, rriddle.
May 29 2020, 3:45 AM · Restricted Project, Restricted Project
dfki-ehna created D80785: [MLIR][BUFFER_PLACEMENT] Introduce CallOp converter for buffer placement.
May 29 2020, 3:45 AM · Restricted Project, Restricted Project
dfki-ehna committed rG7a3a2535854c: [MLIR][BufferPlacement] Support functions that return Memref typed results (authored by dfki-ehna).
[MLIR][BufferPlacement] Support functions that return Memref typed results
May 29 2020, 2:09 AM
dfki-ehna closed D80696: [MLIR][BufferPlacement] Support functions that return Memref typed results.
May 29 2020, 2:08 AM · Restricted Project, Restricted Project
dfki-ehna committed rGced0b8eb2b44: [MLIR][BufferPlacement] Support functions that return Memref typed results (authored by dfki-ehna).
[MLIR][BufferPlacement] Support functions that return Memref typed results
May 29 2020, 1:36 AM
dfki-ehna updated the diff for D80696: [MLIR][BufferPlacement] Support functions that return Memref typed results.

Removing unnecessary mapping.

May 29 2020, 12:30 AM · Restricted Project, Restricted Project
dfki-ehna added inline comments to D80696: [MLIR][BufferPlacement] Support functions that return Memref typed results.
May 29 2020, 12:30 AM · Restricted Project, Restricted Project

May 28 2020

dfki-ehna added inline comments to D80696: [MLIR][BufferPlacement] Support functions that return Memref typed results.
May 28 2020, 7:35 AM · Restricted Project, Restricted Project
dfki-ehna added inline comments to D80696: [MLIR][BufferPlacement] Support functions that return Memref typed results.
May 28 2020, 7:35 AM · Restricted Project, Restricted Project
dfki-ehna updated the diff for D80696: [MLIR][BufferPlacement] Support functions that return Memref typed results.

Change walk return type to WalkResult and move BlockAndValueMapping before adding new arguments to the new block.

May 28 2020, 7:34 AM · Restricted Project, Restricted Project
dfki-ehna added inline comments to D80696: [MLIR][BufferPlacement] Support functions that return Memref typed results.
May 28 2020, 4:50 AM · Restricted Project, Restricted Project
dfki-ehna updated the diff for D80696: [MLIR][BufferPlacement] Support functions that return Memref typed results.

Addressed the comments.

May 28 2020, 4:18 AM · Restricted Project, Restricted Project
dfki-ehna created D80696: [MLIR][BufferPlacement] Support functions that return Memref typed results.
May 28 2020, 1:02 AM · Restricted Project, Restricted Project
dfki-ehna edited reviewers for D80696: [MLIR][BufferPlacement] Support functions that return Memref typed results, added: herhut, pifon2a, mehdi_amini; removed: nicolasvasilache.
May 28 2020, 1:02 AM · Restricted Project, Restricted Project

May 19 2020

dfki-ehna committed rG346830051105: [MLIR] Update the FunctionAndBlockSignatureConverter and… (authored by dfki-ehna).
[MLIR] Update the FunctionAndBlockSignatureConverter and…
May 19 2020, 8:11 AM
dfki-ehna closed D79329: [MLIR] Update the FunctionAndBlockSignatureConverter and NonVoidToVoidReturnOpConverter of Buffer Assignment.
May 19 2020, 8:11 AM · Restricted Project, Restricted Project
dfki-ehna updated the diff for D79329: [MLIR] Update the FunctionAndBlockSignatureConverter and NonVoidToVoidReturnOpConverter of Buffer Assignment.

Change Assert to emitError and add a test case for the generated error.

May 19 2020, 2:08 AM · Restricted Project, Restricted Project

May 15 2020

dfki-ehna updated the diff for D79329: [MLIR] Update the FunctionAndBlockSignatureConverter and NonVoidToVoidReturnOpConverter of Buffer Assignment.

BufferAssignmentPlacer now fails in cases that function returns buffers already. A note has also been added to the description of BufferPlacement.cpp about not supporting these cases. The related TODO in TensorsToBuffers.cpp has also been removed.

May 15 2020, 7:00 AM · Restricted Project, Restricted Project

May 13 2020

dfki-ehna committed rG1b140a87a581: [MLIR] Nested regions test for Buffer Assginment (authored by dfki-ehna).
[MLIR] Nested regions test for Buffer Assginment
May 13 2020, 6:27 AM
dfki-ehna closed D79332: [MLIR] Nested regions test for Buffer Assginment.
May 13 2020, 6:27 AM · Restricted Project, Restricted Project

May 7 2020

dfki-ehna added inline comments to D79329: [MLIR] Update the FunctionAndBlockSignatureConverter and NonVoidToVoidReturnOpConverter of Buffer Assignment.
May 7 2020, 5:37 AM · Restricted Project, Restricted Project

May 5 2020

dfki-ehna added inline comments to D78996: [MLIR][LINALG] Convert Linalg to Linalg.
May 5 2020, 7:30 AM · Restricted Project, Restricted Project
dfki-ehna committed rG6ccaf7388787: [MLIR][LINALG] Convert Linalg on Tensors to Buffers (authored by dfki-ehna).
[MLIR][LINALG] Convert Linalg on Tensors to Buffers
May 5 2020, 6:59 AM
dfki-ehna closed D78996: [MLIR][LINALG] Convert Linalg to Linalg.
May 5 2020, 6:58 AM · Restricted Project, Restricted Project
dfki-ehna added inline comments to D79329: [MLIR] Update the FunctionAndBlockSignatureConverter and NonVoidToVoidReturnOpConverter of Buffer Assignment.
May 5 2020, 6:58 AM · Restricted Project, Restricted Project
dfki-ehna added reviewers for D79332: [MLIR] Nested regions test for Buffer Assginment: mehdi_amini, herhut, pifon2a.
May 5 2020, 6:58 AM · Restricted Project, Restricted Project
dfki-ehna updated the diff for D79332: [MLIR] Nested regions test for Buffer Assginment.

Add description and indent.

May 5 2020, 6:25 AM · Restricted Project, Restricted Project
dfki-ehna updated the diff for D79329: [MLIR] Update the FunctionAndBlockSignatureConverter and NonVoidToVoidReturnOpConverter of Buffer Assignment.

Addressing the comments.

May 5 2020, 6:25 AM · Restricted Project, Restricted Project

May 4 2020

dfki-ehna created D79332: [MLIR] Nested regions test for Buffer Assginment.
May 4 2020, 8:32 AM · Restricted Project, Restricted Project
dfki-ehna updated the summary of D79329: [MLIR] Update the FunctionAndBlockSignatureConverter and NonVoidToVoidReturnOpConverter of Buffer Assignment.
May 4 2020, 7:59 AM · Restricted Project, Restricted Project
dfki-ehna created D79329: [MLIR] Update the FunctionAndBlockSignatureConverter and NonVoidToVoidReturnOpConverter of Buffer Assignment.
May 4 2020, 7:59 AM · Restricted Project, Restricted Project

Apr 30 2020

dfki-ehna added inline comments to D78996: [MLIR][LINALG] Convert Linalg to Linalg.
Apr 30 2020, 9:02 AM · Restricted Project, Restricted Project
dfki-ehna updated the diff for D78996: [MLIR][LINALG] Convert Linalg to Linalg.

Address the comments.

Apr 30 2020, 8:29 AM · Restricted Project, Restricted Project

Apr 29 2020

dfki-ehna added a comment to D78996: [MLIR][LINALG] Convert Linalg to Linalg.

lib/Conversion is intended to for conversions from dialect A to dialect B to ensure it can depend on both without creating unnecessary dependencies A->B or B->A. Since this transformation stays within Linalg, it should go to lib/Dialect/Linalg/Transforms. Beyond being cleaner library-wise, it can have a more meaningful name than "linalg to linalg", e.g. "TensorsToBuffers" or "BufferAssignment".

Apr 29 2020, 5:19 AM · Restricted Project, Restricted Project
dfki-ehna updated the diff for D78996: [MLIR][LINALG] Convert Linalg to Linalg.

Address the comments.

Apr 29 2020, 5:19 AM · Restricted Project, Restricted Project

Apr 28 2020

dfki-ehna added a reviewer for D78996: [MLIR][LINALG] Convert Linalg to Linalg: pifon2a.
Apr 28 2020, 6:24 AM · Restricted Project, Restricted Project
dfki-ehna added reviewers for D78996: [MLIR][LINALG] Convert Linalg to Linalg: mehdi_amini, nicolasvasilache, herhut.
Apr 28 2020, 6:24 AM · Restricted Project, Restricted Project
dfki-ehna created D78996: [MLIR][LINALG] Convert Linalg to Linalg.
Apr 28 2020, 6:24 AM · Restricted Project, Restricted Project

Apr 27 2020

dfki-ehna updated the diff for D78484: Providing buffer assignment for MLIR.

Taking Context and ConversionTarget out of the scope of function walk.

Apr 27 2020, 4:47 AM · Restricted Project, Restricted Project
dfki-ehna added inline comments to D78484: Providing buffer assignment for MLIR.
Apr 27 2020, 3:42 AM · Restricted Project, Restricted Project
dfki-ehna updated the diff for D78484: Providing buffer assignment for MLIR.

Resolve the latest comments.

Apr 27 2020, 3:10 AM · Restricted Project, Restricted Project

Apr 24 2020

dfki-ehna added inline comments to D78484: Providing buffer assignment for MLIR.
Apr 24 2020, 5:54 AM · Restricted Project, Restricted Project
dfki-ehna updated the diff for D78484: Providing buffer assignment for MLIR.

Provide BufferAssignmentTypeConverter for using inside FunctionAndBlockSignatureConverter.

Apr 24 2020, 5:54 AM · Restricted Project, Restricted Project

Apr 23 2020

dfki-ehna added inline comments to D78484: Providing buffer assignment for MLIR.
Apr 23 2020, 8:04 AM · Restricted Project, Restricted Project
dfki-ehna updated the diff for D78484: Providing buffer assignment for MLIR.

Polish BufferPlacement.h

Apr 23 2020, 8:04 AM · Restricted Project, Restricted Project
dfki-ehna updated the diff for D78484: Providing buffer assignment for MLIR.

Resolved second pass comments.

Apr 23 2020, 8:04 AM · Restricted Project, Restricted Project
dfki-ehna added inline comments to D78484: Providing buffer assignment for MLIR.
Apr 23 2020, 6:59 AM · Restricted Project, Restricted Project

Apr 22 2020

dfki-ehna added inline comments to D78484: Providing buffer assignment for MLIR.
Apr 22 2020, 7:00 AM · Restricted Project, Restricted Project
dfki-ehna updated the diff for D78484: Providing buffer assignment for MLIR.

Change NonVoidToVoidReturnOpConverter to use arguments of entry block arguments instead of FuncOp.

Apr 22 2020, 6:28 AM · Restricted Project, Restricted Project
dfki-ehna updated the diff for D78484: Providing buffer assignment for MLIR.

Resolving all the comments and adding description for tests.

Apr 22 2020, 4:17 AM · Restricted Project, Restricted Project

Apr 20 2020

dfki-ehna updated the diff for D78484: Providing buffer assignment for MLIR.

Replacing fake test-purpose operations by Linalg.Generic operations. For testing computeAllocPosition of Buffer Assignment (BA), GenericOpConverter is introduced inside TestBufferAssignmentPreparationPass to convert tensor-type linalg.generic operations to memref ones. FunctionAndBlockSignatureConverter and NonVoidToVoidReturnOpConverter of BA are also tested.

Apr 20 2020, 8:37 AM · Restricted Project, Restricted Project
dfki-ehna added reviewers for D78484: Providing buffer assignment for MLIR: mehdi_amini, rriddle, herhut, pifon2a.
Apr 20 2020, 4:47 AM · Restricted Project, Restricted Project
dfki-ehna created D78484: Providing buffer assignment for MLIR.
Apr 20 2020, 4:47 AM · Restricted Project, Restricted Project