This is an archive of the discontinued LLVM Phabricator instance.

[docs][FileCheck] Fix invalid example
ClosedPublic

Authored by thopre on May 1 2020, 11:28 AM.

Details

Summary

FileCheck documentation contains an example of a numeric variable
defined and used on the same line. This is not currently supported by
FileCheck so this commit fixes the example to use CHECK-SAME for the
variable use.

Test Plan: copy/pasted the example and tested with FileCheck without
this patch (failed) and with (succeeded).

Diff Detail

Event Timeline

thopre created this revision.May 1 2020, 11:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 1 2020, 11:28 AM
MaskRay accepted this revision.May 1 2020, 4:05 PM

LGTM. I remember you have a large patch series improving FileCheck. How many have landed now? If not all have landed, what is blocking the remaining changes?

This revision is now accepted and ready to land.May 1 2020, 4:05 PM
thopre added a comment.May 2 2020, 3:30 PM

LGTM. I remember you have a large patch series improving FileCheck. How many have landed now? If not all have landed, what is blocking the remaining changes?

9/12 of the patch series and plenty cleanup along the way. 11/12 is a tiny one and I'm not sure about 12/12 because it comes with potential pitfalls (allowing to use a variable defined on the same line). Nothing's blocking 10/12 except for the little amount of free time I have to progress on it but I'm actively working on it. Hopefully I can update the review (D60390) in 1-2 weeks time.

This revision was automatically updated to reflect the committed changes.