Page MenuHomePhabricator

[SVE][CodeGen] Legalisation of vsetcc with scalable types
ClosedPublic

Authored by kmclaughlin on Apr 30 2020, 5:57 AM.

Details

Summary

Changes SplitVecOp_VSETCC to use getVectorElementCount()

Diff Detail

Event Timeline

kmclaughlin created this revision.Apr 30 2020, 5:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 30 2020, 5:57 AM
kmclaughlin retitled this revision from [SVE][CodeGen] Legalise scalable vector types for vsetcc & vselect to [SVE][CodeGen] Legalisation of vsetcc with scalable types.
kmclaughlin edited the summary of this revision. (Show Details)
  • Rebased patch & updated checks in the tests with update_llc_test_checks.py
efriedma accepted this revision.Wed, Jun 17, 11:25 AM

Is it possible to write tests for this that don't result in a "max" or "min" operation? Or does that fail for some other reason?

Otherwise LGTM.

This revision is now accepted and ready to land.Wed, Jun 17, 11:25 AM

Added tests to llvm-ir-to-intrinsic.ll which check the results of compare instructions

Is it possible to write tests for this that don't result in a "max" or "min" operation? Or does that fail for some other reason?

Otherwise LGTM.

Thanks for reviewing this, @efriedma. It was possible to add tests which don't result in a min/max by returning the result of the compare.

This revision was automatically updated to reflect the committed changes.