This is an archive of the discontinued LLVM Phabricator instance.

Differential D79143

[mlir][StandardToSPIRV] Add support for lowering integer casting.
ClosedPublic

Authored by hanchung on Apr 29 2020, 4:30 PM.

Download Raw Diff

Details

Reviewers

mravishankar
antiagainst
denis13

Commits

rGbe0ad5b034b2: [mlir][StandardToSPIRV] Add support for lowering integer casting.

Summary

Maps ZeroExtendIOp and TruncateIOp to spirv::UConvertOp and spirv::SConvertOp.

Depends On D78974

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	50 ms	MLIR.Conversion/StandardToSPIRV::Unknown Unit Message ("")
	80 ms	MLIR.Conversion/StandardToSPIRV::Unknown Unit Message ("")

Event Timeline

hanchung created this revision.Apr 29 2020, 4:30 PM

Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2020, 4:30 PM

Herald added subscribers: llvm-commits, Kayjukh, frgossen and 12 others. · View Herald Transcript

Add tests.

Harbormaster failed remote builds in B55232: Diff 261098!Apr 29 2020, 5:50 PM

Harbormaster failed remote builds in B55225: Diff 261089!

antiagainst requested changes to this revision.Apr 30 2020, 11:55 AM

antiagainst added inline comments.

mlir/lib/Conversion/StandardToSPIRV/ConvertStandardToSPIRV.cpp
757	Shouldn't we use UConvert here?

This revision now requires changes to proceed.Apr 30 2020, 11:55 AM

Address comments.

mlir/lib/Conversion/StandardToSPIRV/ConvertStandardToSPIRV.cpp
757	good catch...thanks!

hanchung edited the summary of this revision. (Show Details)Apr 30 2020, 3:29 PM

antiagainst accepted this revision.Apr 30 2020, 3:31 PM

This revision is now accepted and ready to land.Apr 30 2020, 3:31 PM

Harbormaster completed remote builds in B55382: Diff 261376.Apr 30 2020, 4:07 PM

Closed by commit rGbe0ad5b034b2: [mlir][StandardToSPIRV] Add support for lowering integer casting. (authored by hanchung). · Explain WhyApr 30 2020, 7:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

mlir/

lib/

Conversion/

StandardToSPIRV/

ConvertStandardToSPIRV.cpp

2 lines

Diff 261089

mlir/lib/Conversion/StandardToSPIRV/ConvertStandardToSPIRV.cpp

	Show First 20 Lines • Show All 748 Lines • ▼ Show 20 Lines		patterns.insert<
	UnaryAndBinaryOpPattern<UnsignedRemIOp, spirv::UModOp>,			UnaryAndBinaryOpPattern<UnsignedRemIOp, spirv::UModOp>,
	UnaryAndBinaryOpPattern<UnsignedShiftRightOp, spirv::ShiftRightLogicalOp>,			UnaryAndBinaryOpPattern<UnsignedShiftRightOp, spirv::ShiftRightLogicalOp>,
	BitwiseOpPattern<AndOp, spirv::LogicalAndOp, spirv::BitwiseAndOp>,			BitwiseOpPattern<AndOp, spirv::LogicalAndOp, spirv::BitwiseAndOp>,
	BitwiseOpPattern<OrOp, spirv::LogicalOrOp, spirv::BitwiseOrOp>,			BitwiseOpPattern<OrOp, spirv::LogicalOrOp, spirv::BitwiseOrOp>,
	BoolCmpIOpPattern, ConstantCompositeOpPattern, ConstantScalarOpPattern,			BoolCmpIOpPattern, ConstantCompositeOpPattern, ConstantScalarOpPattern,
	CmpFOpPattern, CmpIOpPattern, IntLoadOpPattern, LoadOpPattern,			CmpFOpPattern, CmpIOpPattern, IntLoadOpPattern, LoadOpPattern,
	ReturnOpPattern, SelectOpPattern, StoreOpPattern,			ReturnOpPattern, SelectOpPattern, StoreOpPattern,
	TypeCastingOpPattern<SIToFPOp, spirv::ConvertSToFOp>,			TypeCastingOpPattern<SIToFPOp, spirv::ConvertSToFOp>,
				TypeCastingOpPattern<ZeroExtendIOp, spirv::SConvertOp>,
				antiagainstUnsubmitted Done Reply Inline Actions Shouldn't we use UConvert here? antiagainst: Shouldn't we use UConvert here?
				hanchungAuthorUnsubmitted Done Reply Inline Actions good catch...thanks! hanchung: good catch...thanks!
				TypeCastingOpPattern<TruncateIOp, spirv::SConvertOp>,
	TypeCastingOpPattern<FPExtOp, spirv::FConvertOp>,			TypeCastingOpPattern<FPExtOp, spirv::FConvertOp>,
	TypeCastingOpPattern<FPTruncOp, spirv::FConvertOp>, XOrOpPattern>(			TypeCastingOpPattern<FPTruncOp, spirv::FConvertOp>, XOrOpPattern>(
	context, typeConverter);			context, typeConverter);
	}			}
	} // namespace mlir			} // namespace mlir