This is an archive of the discontinued LLVM Phabricator instance.

[X86] Don't return true from isTruncateFree for vectors
ClosedPublic

Authored by craig.topper on Apr 28 2020, 2:37 PM.

Details

Summary

Also fix some cost tables for vXi1 types to match the costs entries for the types they will be promoted to.

Diff Detail

Event Timeline

craig.topper created this revision.Apr 28 2020, 2:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2020, 2:37 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
RKSimon added inline comments.Apr 29 2020, 4:33 AM
llvm/lib/Target/X86/X86ISelLowering.cpp
30600

Do we need some kind of hasSSE() check to prevent the i686 regression in llvm/test/CodeGen/X86/shift-combine.ll ?

Enabled a DAG combine post type legalization with a LegalTypes check to avoid a regression shift-combine.ll

RKSimon accepted this revision.Apr 30 2020, 2:14 PM

LGTM cheers

This revision is now accepted and ready to land.Apr 30 2020, 2:14 PM
This revision was automatically updated to reflect the committed changes.