This enforces layering, reduces a sprawling clangd/ directory, and makes life
easier for embedders.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Of the pieces I was unsure about:
- I didn't move Protocol - it's not a perfect fit, though it may still end up here
- I moved FSProvider but not FS
- I didn't move URI - I suspect that will *probably* end up wherever Protocol does, though it may belong in support even if protocol doesn't.
Looks like this is causing buildbot failure when built with -DBUILD_SHARED_LIBS=ON.
http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/3077/steps/build%20stage%201/logs/stdio
FAILED: lib/libclangDaemon.so.11git : && /home/buildbots/clang.9.0.0/bin/clang++ -... && : tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/CodeComplete.cpp.o:(.toc+0x120): undefined reference to `pthread_create' clang++: error: linker command failed with exit code 1 (use -v to see invocation)
Thanks, bc029fa6c5cdc28fa2087f721e5ffe27d9b24ecd should fix this.
Will keep an eye on it (didn't get mail last time, maybe it was already broken).
I think there's more, just running a local shared build so I can catch them (I should really have done this ahead of time).
OK, this now builds for me in shared mode after e7a7deb60ab0ee4ccd9e1f0de8e164b615344ae2
Ah, I've done that (since I primarily build in the shared mode, though I temporarily switched to static to resolve recent shared index issues) but didn't only built some of the targets, should've done all of them; my bad too, sorry.