[mlir][spirv] Fix SPIR-V translation registration

[antiagainst]

Summary

Now we must explicitly call the registration function given that
MLIR moved away from static registration.

[mravishankar]

Just a nit about commit message. This should also expose -deserialize-spirv right?

[antiagainst]

Address comments

[antiagainst]

In D78934#2005577, @mravishankar wrote:

Just a nit about commit message. This should also expose -deserialize-spirv right?

It's actually -serialize-spirv. But yes indeed the registration function name should be swapped. Fixed.

mlir/include/mlir/InitAllTranslations.h

 //===----------------------------------------------------------------------===//
 
 #ifndef MLIR_INITALLTRANSLATIONS_H
 #define MLIR_INITALLTRANSLATIONS_H
 
 namespace mlir {
 
 void registerFromLLVMIRTranslation();
+void registerFromSPIRVTranslation();
 void registerToLLVMIRTranslation();
 void registerToSPIRVTranslation();
 void registerToNVVMIRTranslation();
 void registerToROCLDIRTranslation();
 void registerAVX512ToLLVMIRTranslation();
 
 // This function should be called before creating any MLIRContext if one
 // expects all the possible translations to be made available to the context
 // automatically.
 inline void registerAllTranslations() {
   static bool init_once = []() {
     registerFromLLVMIRTranslation();
+    registerFromSPIRVTranslation();
     registerToLLVMIRTranslation();
     registerToSPIRVTranslation();
     registerToNVVMIRTranslation();
     registerToROCLDIRTranslation();
     registerAVX512ToLLVMIRTranslation();
     return true;
   }();
   (void)init_once;
 }
 } // namespace mlir
 
 #endif // MLIR_INITALLTRANSLATIONS_H

mlir/lib/Dialect/SPIRV/Serialization/TranslateRegistration.cpp

static OwningModuleRef deserializeModule(const llvm::MemoryBuffer *input,
   OwningModuleRef module(ModuleOp::create(FileLineColLoc::get(
       input->getBufferIdentifier(), /*line=*/0, /*column=*/0, context)));
   module->getBody()->push_front(spirvModule->getOperation());
 
   return module;
 }
 
 namespace mlir {
-void registerToSPIRVTranslation() {
+void registerFromSPIRVTranslation() {
   TranslateToMLIRRegistration fromBinary(
       "deserialize-spirv",
       [](llvm::SourceMgr &sourceMgr, MLIRContext *context) {
         assert(sourceMgr.getNumBuffers() == 1 && "expected one buffer");
         return deserializeModule(
             sourceMgr.getMemoryBuffer(sourceMgr.getMainFileID()), context);
       });
 }
static LogicalResult serializeModule(ModuleOp module, raw_ostream &output) {
 
   output.write(reinterpret_cast<char *>(binary.data()),
                binary.size() * sizeof(uint32_t));
 
   return mlir::success();
 }
 
 namespace mlir {
-void registerFromSPIRVTranslation() {
+void registerToSPIRVTranslation() {
   TranslateFromMLIRRegistration toBinary(
       "serialize-spirv", [](ModuleOp module, raw_ostream &output) {
         return serializeModule(module, output);
       });
 }
 } // namespace mlir
 
 //===----------------------------------------------------------------------===//