Page MenuHomePhabricator
Differential D78930

[MLIR] Give AffineStoreOp and AffineLoadOp Memory SideEffects.
ClosedPublic
Actions

Authored by tpopp on Apr 27 2020, 7:55 AM.

Details

Reviewers
nicolasvasilache
mehdi_amini
rriddle
Commits
rGf66c87637a52: [MLIR] Give AffineStoreOp and AffineLoadOp Memory SideEffects.
Summary

This change results in tests also being changed to prevent dead
affine.load operations from being folded away during rewrites.

Also move AffineStoreOp and AffineLoadOp to an ODS file.

Diff Detail

Event Timeline

tpopp created this revision.Apr 27 2020, 7:55 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptApr 27 2020, 7:55 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, Kayjukh, frgossen and 13 others. · View Herald Transcript
Harbormaster failed remote builds in B54804: Diff 260324!Apr 27 2020, 8:34 AM
mehdi_amini accepted this revision.Apr 27 2020, 12:55 PM
This revision is now accepted and ready to land.Apr 27 2020, 12:55 PM
rriddle accepted this revision.Apr 27 2020, 1:11 PM
rriddle added inline comments.
mlir/include/mlir/Dialect/Affine/IR/AffineOps.td
833

Can you keep this file sorted alphabetically?

tpopp updated this revision to Diff 260569.Apr 28 2020, 2:04 AM
tpopp marked an inline comment as done.

Reorder definition of ops and handle a rebase.

Harbormaster failed remote builds in B54935: Diff 260569!Apr 28 2020, 2:39 AM
nicolasvasilache accepted this revision.Apr 28 2020, 6:32 AM
Closed by commit rGf66c87637a52: [MLIR] Give AffineStoreOp and AffineLoadOp Memory SideEffects. (authored by Tres Popp <tpopp@google.com>). · Explain WhyApr 28 2020, 6:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
Affine/
IR/
141 lines
149 lines
lib/
Dialect/
Affine/
IR/
99 lines
test/
Dialect/
Affine/
10 lines
52 lines
Transforms/
21 lines
10 lines
24 lines

Diff 260625

View Options

mlir/include/mlir/Dialect/Affine/IR/AffineOps.h

Loading...
View Options

mlir/include/mlir/Dialect/Affine/IR/AffineOps.td

Loading...
View Options

mlir/lib/Dialect/Affine/IR/AffineOps.cpp

Loading...
View Options

mlir/test/Dialect/Affine/canonicalize.mlir

Loading...
View Options

mlir/test/Dialect/Affine/loop-unswitch.mlir

Loading...
View Options

mlir/test/Transforms/canonicalize.mlir

Loading...
View Options

mlir/test/Transforms/loop-fusion-transformation.mlir

Loading...
View Options

mlir/test/Transforms/memref-normalize.mlir

Loading...