Page MenuHomePhabricator

[MLIR] Use nested symbol to identify kernel in `LaunchFuncOp`.
ClosedPublic

Authored by frgossen on Apr 21 2020, 3:21 AM.

Details

Summary

Use a nested symbol to identify the kernel to be invoked by a LaunchFuncOp in the GPU dialect.
This replaces the two attributes that were used to identify the kernel module and the kernel within seperately.

Diff Detail

Event Timeline

frgossen created this revision.Apr 21 2020, 3:21 AM
ftynse accepted this revision.Apr 21 2020, 3:49 AM

Thanks, this cleanup was long overdue

herhut accepted this revision.Apr 21 2020, 4:41 AM

So much nicer, thank you!

antiagainst accepted this revision.Apr 21 2020, 5:08 AM
rriddle accepted this revision.Apr 21 2020, 11:13 AM
rriddle added inline comments.
mlir/include/mlir/IR/SymbolTable.h
12

The include is unnecessary.

mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
17

This is unnecessary.

This revision is now accepted and ready to land.Apr 21 2020, 11:13 AM
This revision was automatically updated to reflect the committed changes.