Also capitalized some induction variables, to match coding style.
I don't understand why this block exists. We already returned if it wasn't a callsite.
This should be a cast I think.
Nice catch! Indeed, 557 took care of it.
Needs to be CB->getArgOperand. This is making my DEBUG build fail.
Noted, doing a rebuild locally to validate there's no other failures and sending a fix asap. Sorry about this.
(It might be a really good idea to do all local development with LLVM_ENABLE_ASSERTIONS enabled..)
Just saw the discussions here. I fixed it in cca545ce462b61bdd4bd1b8d81d9eb921e13aebc
For a CMAKE_BUILD_TYPE=Release build, -DLLVM_ENABLE_ASSERTIONS defaults to OFF. It may be good setting it to ON.
+1 - good suggestion, you mean locally, I assume.