This is an archive of the discontinued LLVM Phabricator instance.

[IPT] Don't use OrderedInstructions (NFC)
ClosedPublic

Authored by nikic on Apr 19 2020, 1:17 PM.

Details

Summary

Use Instruction::comesBefore() instead of OrderedInstructions inside InstructionPrecedenceTracking. This also removes the dominator tree dependency.

Diff Detail

Event Timeline

nikic created this revision.Apr 19 2020, 1:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2020, 1:17 PM
fhahn accepted this revision.Apr 19 2020, 1:38 PM

LGTM, thanks!

This revision is now accepted and ready to land.Apr 19 2020, 1:38 PM
MaskRay added inline comments.
include/llvm/Analysis/InstructionPrecedenceTracking.h
51–52

Delete the default constructor.

95–96

ditto

nikic updated this revision to Diff 258625.Apr 19 2020, 2:44 PM

Remove trivial constructors.

nikic updated this revision to Diff 258626.Apr 19 2020, 2:46 PM
nikic marked 2 inline comments as done.

Remove one more constructor...

MaskRay accepted this revision.Apr 19 2020, 3:05 PM

LGTM.

This revision was automatically updated to reflect the committed changes.