Paths

Table of Contentst

Differential D78426

[MLIR] Move `replaceAllUsesExcept` from LoopUtil.h to Value.h.
ClosedPublic
Actions

Authored by pifon2a on Apr 18 2020, 7:00 AM.

Details

Reviewers

nicolasvasilache
rriddle
ftynse
bondhugula

Commits

rGad9988f4da95: [MLIR] Move `replaceAllUsesExcept` from LoopUtil.h to Value.h.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

pifon2a created this revision.Apr 18 2020, 7:00 AM

Herald added a reviewer: nicolasvasilache. · View Herald TranscriptApr 18 2020, 7:01 AM

Herald added a reviewer: rriddle. · View Herald Transcript

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: llvm-commits, frgossen, grosul1 and 12 others. · View Herald Transcript

Harbormaster failed remote builds in B53846: Diff 258519!Apr 18 2020, 7:01 AM

pifon2a added reviewers: ftynse, bondhugula.Apr 18 2020, 7:04 AM

Thanks!

mlir/include/mlir/IR/Value.h
141	Nit: with the new value -> with `newValue`

rriddle accepted this revision.Apr 18 2020, 10:49 AM

rriddle added inline comments.

mlir/include/mlir/IR/Value.h
19	Please don't add includes here, if it is truly necessary move it to the .cpp file.
mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp
111–112	nit: Change the type of newIndex to AddIOp to avoid needing to recover the defining op.

This revision is now accepted and ready to land.Apr 18 2020, 10:49 AM

bondhugula added inline comments.Apr 18 2020, 10:08 PM

mlir/include/mlir/IR/Value.h
19	This include is actually not necessary. SmallPtrSet and its impl is already fwd decl'ed in mlir/Support/LLVM.h.

Addressed the comments.

pifon2a marked 4 inline comments as done.Apr 20 2020, 12:20 AM

Harbormaster failed remote builds in B53934: Diff 258667!Apr 20 2020, 12:30 AM

Closed by commit rGad9988f4da95: [MLIR] Move `replaceAllUsesExcept` from LoopUtil.h to Value.h. (authored by pifon2a). · Explain WhyApr 20 2020, 12:30 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

mlir/

include/

mlir/

IR/

7 lines

Transforms/

5 lines

lib/

Dialect/

Linalg/

Transforms/

10 lines

IR/

12 lines

Transforms/

Utils/

12 lines

Diff 258670

mlir/include/mlir/IR/Value.h

Loading...

mlir/include/mlir/Transforms/LoopUtils.h

Loading...

mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp

Loading...

mlir/lib/IR/Value.cpp

Loading...

mlir/lib/Transforms/Utils/LoopUtils.cpp

Loading...