Page MenuHomePhabricator

[MLIR] Move `replaceAllUsesExcept` from LoopUtil.h to Value.h.
ClosedPublic

Authored by pifon2a on Apr 18 2020, 7:00 AM.

Diff Detail

Event Timeline

pifon2a created this revision.Apr 18 2020, 7:00 AM
bondhugula accepted this revision.Apr 18 2020, 7:18 AM

Thanks!

mlir/include/mlir/IR/Value.h
141

Nit: with the new value -> with newValue

rriddle accepted this revision.Apr 18 2020, 10:49 AM
rriddle added inline comments.
mlir/include/mlir/IR/Value.h
19

Please don't add includes here, if it is truly necessary move it to the .cpp file.

mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp
111–112

nit: Change the type of newIndex to AddIOp to avoid needing to recover the defining op.

This revision is now accepted and ready to land.Apr 18 2020, 10:49 AM
bondhugula added inline comments.Apr 18 2020, 10:08 PM
mlir/include/mlir/IR/Value.h
19

This include is actually not necessary. SmallPtrSet and its impl is already fwd decl'ed in mlir/Support/LLVM.h.

pifon2a updated this revision to Diff 258667.Apr 20 2020, 12:18 AM

Addressed the comments.

pifon2a marked 4 inline comments as done.Apr 20 2020, 12:20 AM
This revision was automatically updated to reflect the committed changes.