Do not count the presence of debug insts against the limit set by
LdStLimit, and allow the optimizer to find matching insts by skipping
over debug insts.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Apologies, this was uploaded too early. This patch still needs cleanup before it's ready to be reviewed.
llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp | ||
---|---|---|
751 | could use range based iterator? | |
1013 | nit: Not sure if it is worth to introduce a variable for a single use, as it also increases the number of variables to keep track in the function. | |
llvm/test/CodeGen/AArch64/ldst-opt-mte.mir | ||
1 | I think it would be slightly better to have the version with DBG_VALUE as separate test, as it unnecessarily clutters the test with respect to the core functionality. |
Address review feedback:
- Use range based iterator, split out a second test with debug info, drop extra variable
llvm/test/CodeGen/AArch64/ldst-opt-mte.mir | ||
---|---|---|
1 | I see; let's add a -mir-debugify run line to the original test so that extensions to the pass get tested with debug info, and then copy the test to have coverage for the case where there are multiple DBG_VALUEs between instruction pairs? |
could use range based iterator?