Libraries declared as target_link_libraries() do not also need
to be declared as dependencies using add_dependencies().
Depends on D78317
Paths
| Differential D78320
[MLIR][cmake] Remove redundant add_dependencies() ClosedPublic Authored by stephenneuendorffer on Apr 16 2020, 12:29 PM.
Details
Summary Libraries declared as target_link_libraries() do not also need Depends on D78317
Diff Detail
Event Timelinestephenneuendorffer added a child revision: D78321: [MLIR][cmake] Use DEPENDS instead of add_dependencies().Apr 16 2020, 12:30 PM Comment Actions Looks good. Are the build failures related to this? I somehow can't get a log chasing the link https://reviews.llvm.org/harbormaster/build/61155/. Comment Actions
I almost never see the harbormaster tests passing, so (unfortunately) I've taken to ignoring them. Closed by commit rG314f00a03489: [MLIR][cmake] Remove redundant add_dependencies() (authored by stephenneuendorffer). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 258129 mlir/lib/Conversion/AVX512ToLLVM/CMakeLists.txt
mlir/lib/Conversion/LinalgToLLVM/CMakeLists.txt
mlir/lib/Conversion/VectorToLLVM/CMakeLists.txt
mlir/lib/Conversion/VectorToLoops/CMakeLists.txt
mlir/lib/EDSC/CMakeLists.txt
|