This is an archive of the discontinued LLVM Phabricator instance.

Differential D78321

[MLIR][cmake] Use DEPENDS instead of add_dependencies()
ClosedPublic

Authored by stephenneuendorffer on Apr 16 2020, 12:30 PM.

Details

Reviewers
None
Commits
rG26805f0b6408: [MLIR][cmake] Use DEPENDS instead of add_dependencies()
Summary

add_llvm_library() sometimes needs access to the dependencies in order to
generate new targets. Using DEPENDS allows this.

Depends on D78320

Diff Detail

Event Timeline

stephenneuendorffer created this revision.Apr 16 2020, 12:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 16 2020, 12:30 PM
Herald added subscribers: llvm-commits, frgossen, grosul1 and 13 others. · View Herald Transcript
Harbormaster failed remote builds in B53612: Diff 258130!Apr 16 2020, 12:50 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 16 2020, 4:11 PM
Closed by commit rG26805f0b6408: [MLIR][cmake] Use DEPENDS instead of add_dependencies() (authored by stephenneuendorffer). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
lib/
Interfaces/
24 lines

Diff 258195

mlir/lib/Interfaces/CMakeLists.txt

set(LLVM_OPTIONAL_SOURCES set(LLVM_OPTIONAL_SOURCES
CallInterfaces.cpp CallInterfaces.cpp
ControlFlowInterfaces.cpp ControlFlowInterfaces.cpp
DerivedAttributeOpInterface.cpp DerivedAttributeOpInterface.cpp
InferTypeOpInterface.cpp InferTypeOpInterface.cpp
LoopLikeInterface.cpp LoopLikeInterface.cpp
SideEffects.cpp SideEffects.cpp
) )
add_mlir_library(MLIRCallInterfaces add_mlir_library(MLIRCallInterfaces
CallInterfaces.cpp CallInterfaces.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces ${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces
)
add_dependencies(MLIRCallInterfaces DEPENDS
MLIRCallInterfacesIncGen MLIRCallInterfacesIncGen
) )
target_link_libraries(MLIRCallInterfaces target_link_libraries(MLIRCallInterfaces
PUBLIC PUBLIC
MLIRIR MLIRIR
) )
add_mlir_library(MLIRControlFlowInterfaces add_mlir_library(MLIRControlFlowInterfaces
ControlFlowInterfaces.cpp ControlFlowInterfaces.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces ${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces
)
add_dependencies(MLIRControlFlowInterfaces DEPENDS
MLIRControlFlowInterfacesIncGen MLIRControlFlowInterfacesIncGen
) )
target_link_libraries(MLIRControlFlowInterfaces target_link_libraries(MLIRControlFlowInterfaces
PUBLIC PUBLIC
MLIRIR MLIRIR
) )
add_mlir_library(MLIRDerivedAttributeOpInterface add_mlir_library(MLIRDerivedAttributeOpInterface
DerivedAttributeOpInterface.cpp DerivedAttributeOpInterface.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces ${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces
)
add_dependencies(MLIRDerivedAttributeOpInterface DEPENDS
MLIRDerivedAttributeOpInterfaceIncGen MLIRDerivedAttributeOpInterfaceIncGen
) )
target_link_libraries(MLIRDerivedAttributeOpInterface target_link_libraries(MLIRDerivedAttributeOpInterface
PUBLIC PUBLIC
MLIRIR MLIRIR
) )
add_mlir_library(MLIRInferTypeOpInterface add_mlir_library(MLIRInferTypeOpInterface
InferTypeOpInterface.cpp InferTypeOpInterface.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces ${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces
)
add_dependencies(MLIRInferTypeOpInterface DEPENDS
MLIRInferTypeOpInterfaceIncGen MLIRInferTypeOpInterfaceIncGen
) )
target_link_libraries(MLIRInferTypeOpInterface target_link_libraries(MLIRInferTypeOpInterface
PUBLIC PUBLIC
MLIRIR MLIRIR
) )
add_mlir_library(MLIRLoopLikeInterface add_mlir_library(MLIRLoopLikeInterface
LoopLikeInterface.cpp LoopLikeInterface.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces ${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces
)
add_dependencies(MLIRLoopLikeInterface DEPENDS
MLIRLoopLikeInterfaceIncGen MLIRLoopLikeInterfaceIncGen
) )
target_link_libraries(MLIRLoopLikeInterface target_link_libraries(MLIRLoopLikeInterface
PUBLIC PUBLIC
MLIRIR MLIRIR
) )
add_mlir_library(MLIRSideEffects add_mlir_library(MLIRSideEffects
SideEffects.cpp SideEffects.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces ${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces
)
add_dependencies(MLIRSideEffects DEPENDS
MLIRSideEffectOpInterfacesIncGen MLIRSideEffectOpInterfacesIncGen
) )
target_link_libraries(MLIRSideEffects target_link_libraries(MLIRSideEffects
PUBLIC PUBLIC
MLIRIR MLIRIR
) )