This is an archive of the discontinued LLVM Phabricator instance.

Differential D78320

[MLIR][cmake] Remove redundant add_dependencies()
ClosedPublic

Authored by stephenneuendorffer on Apr 16 2020, 12:29 PM.

Details

Reviewers
aartbik
Commits
rG314f00a03489: [MLIR][cmake] Remove redundant add_dependencies()
Summary

Libraries declared as target_link_libraries() do not also need
to be declared as dependencies using add_dependencies().

Depends on D78317

Diff Detail

Event Timeline

stephenneuendorffer created this revision.Apr 16 2020, 12:29 PM
Herald added a reviewer: aartbik. · View Herald TranscriptApr 16 2020, 12:29 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, frgossen, grosul1 and 14 others. · View Herald Transcript
stephenneuendorffer added a child revision: D78321: [MLIR][cmake] Use DEPENDS instead of add_dependencies().Apr 16 2020, 12:30 PM
Harbormaster failed remote builds in B53611: Diff 258129!Apr 16 2020, 12:50 PM
bondhugula added a subscriber: bondhugula.Apr 16 2020, 12:54 PM

Looks good. Are the build failures related to this? I somehow can't get a log chasing the link https://reviews.llvm.org/harbormaster/build/61155/.

stephenneuendorffer added a comment.Apr 16 2020, 1:38 PM
In D78320#1987429, @bondhugula wrote:

Looks good. Are the build failures related to this? I somehow can't get a log chasing the link https://reviews.llvm.org/harbormaster/build/61155/.

I almost never see the harbormaster tests passing, so (unfortunately) I've taken to ignoring them.
I wish we could trust them.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 16 2020, 3:05 PM
Closed by commit rG314f00a03489: [MLIR][cmake] Remove redundant add_dependencies() (authored by stephenneuendorffer). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
lib/
Conversion/
AVX512ToLLVM/
6 lines
LinalgToLLVM/
9 lines
VectorToLLVM/
9 lines
VectorToLoops/
9 lines
EDSC/
1 line

Diff 258183

mlir/lib/Conversion/AVX512ToLLVM/CMakeLists.txt

add_mlir_conversion_library(MLIRAVX512ToLLVM add_mlir_conversion_library(MLIRAVX512ToLLVM
ConvertAVX512ToLLVM.cpp ConvertAVX512ToLLVM.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/AVX512ToLLVM ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/AVX512ToLLVM
DEPENDS DEPENDS
MLIRConversionPassIncGen MLIRConversionPassIncGen
) )
set(LIBS target_link_libraries(MLIRAVX512ToLLVM
PUBLIC
MLIRAVX512 MLIRAVX512
MLIRLLVMAVX512 MLIRLLVMAVX512
MLIRLLVMIR MLIRLLVMIR
MLIRStandardToLLVM MLIRStandardToLLVM
MLIRTransforms MLIRTransforms
LLVMCore LLVMCore
LLVMSupport LLVMSupport
) )
add_dependencies(MLIRAVX512ToLLVM ${LIBS})
target_link_libraries(MLIRAVX512ToLLVM PUBLIC ${LIBS})

mlir/lib/Conversion/LinalgToLLVM/CMakeLists.txt

add_mlir_conversion_library(MLIRLinalgToLLVM add_mlir_conversion_library(MLIRLinalgToLLVM
LinalgToLLVM.cpp LinalgToLLVM.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/LinalgToLLVM ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/LinalgToLLVM
DEPENDS DEPENDS
MLIRConversionPassIncGen MLIRConversionPassIncGen
) )
set(LIBS
target_link_libraries(MLIRLinalgToLLVM
PUBLIC
MLIRAffineToStandard MLIRAffineToStandard
MLIREDSC MLIREDSC
MLIRIR MLIRIR
MLIRLinalgOps MLIRLinalgOps
MLIRLLVMIR MLIRLLVMIR
MLIRLoopToStandard MLIRLoopToStandard
MLIRStandardToLLVM MLIRStandardToLLVM
MLIRVectorToLLVM MLIRVectorToLLVM
MLIRTransforms MLIRTransforms
LLVMCore LLVMCore
LLVMSupport LLVMSupport
) )
add_dependencies(MLIRLinalgToLLVM ${LIBS})
target_link_libraries(MLIRLinalgToLLVM
PUBLIC
${LIBS})

mlir/lib/Conversion/VectorToLLVM/CMakeLists.txt

add_mlir_conversion_library(MLIRVectorToLLVM add_mlir_conversion_library(MLIRVectorToLLVM
ConvertVectorToLLVM.cpp ConvertVectorToLLVM.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/VectorToLLVM ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/VectorToLLVM
DEPENDS DEPENDS
MLIRConversionPassIncGen MLIRConversionPassIncGen
) )
set(LIBS
target_link_libraries(MLIRVectorToLLVM
PUBLIC
MLIRLLVMIR MLIRLLVMIR
MLIRStandardToLLVM MLIRStandardToLLVM
MLIRVector MLIRVector
MLIRTransforms MLIRTransforms
LLVMCore LLVMCore
LLVMSupport LLVMSupport
) )
add_dependencies(MLIRVectorToLLVM ${LIBS})
target_link_libraries(MLIRVectorToLLVM
PUBLIC
${LIBS})

mlir/lib/Conversion/VectorToLoops/CMakeLists.txt

add_mlir_conversion_library(MLIRVectorToLoops add_mlir_conversion_library(MLIRVectorToLoops
ConvertVectorToLoops.cpp ConvertVectorToLoops.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/VectorToLoops ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/VectorToLoops
) )
set(LIBS
target_link_libraries(MLIRVectorToLoops
PUBLIC
MLIREDSC MLIREDSC
MLIRAffineEDSC MLIRAffineEDSC
MLIRLLVMIR MLIRLLVMIR
MLIRTransforms MLIRTransforms
LLVMCore LLVMCore
LLVMSupport LLVMSupport
) )
add_dependencies(MLIRVectorToLoops ${LIBS})
target_link_libraries(MLIRVectorToLoops
PUBLIC
${LIBS})

mlir/lib/EDSC/CMakeLists.txt

Show All 16 Linestarget_link_libraries(MLIREDSC
) )
add_mlir_library(MLIREDSCInterface add_mlir_library(MLIREDSCInterface
CoreAPIs.cpp CoreAPIs.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/EDSC ${MLIR_MAIN_INCLUDE_DIR}/mlir/EDSC
) )
add_dependencies(MLIREDSCInterface MLIRIR)
target_link_libraries(MLIREDSCInterface target_link_libraries(MLIREDSCInterface
PUBLIC PUBLIC
MLIRIR MLIRIR
MLIRSupport MLIRSupport
MLIRParser MLIRParser
) )