Page MenuHomePhabricator
Differential D78290

Move [[gsl::Pointer]] into llvm/include/llvm/Support/Compiler.h
ClosedPublic
Actions

Authored by mgehre on Apr 16 2020, 3:34 AM.

Details

Reviewers
RKSimon
mstorsjo
bondhugula
labath
aaron.ballman
Summary

Make [[gsl::Pointer]] conditional on compiler support

Diff Detail

Event Timeline

mgehre created this revision.Apr 16 2020, 3:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 16 2020, 3:34 AM
Herald added a subscriber: dexonsmith. · View Herald Transcript
mgehre updated this revision to Diff 258007.Apr 16 2020, 3:35 AM

Fix typo

Harbormaster failed remote builds in B53542: Diff 258007!Apr 16 2020, 3:57 AM
Harbormaster failed remote builds in B53541: Diff 258006!
RKSimon added a comment.Apr 16 2020, 4:44 AM

I can confirm this works for MSVC builds

aaron.ballman accepted this revision.Apr 16 2020, 4:51 AM
aaron.ballman added a subscriber: aaron.ballman.

LGTM!

This revision is now accepted and ready to land.Apr 16 2020, 4:51 AM
RKSimon accepted this revision.Apr 16 2020, 4:54 AM

Confirmed on ubuntu gcc7.5 as well - LGTM, cheers.

mgehre closed this revision.Apr 16 2020, 5:11 AM

Committed as 6d2f73f821ed5ea584869924b150ac2e6e65c12e

MaskRay mentioned this in D80225: [Driver] Recognize -fuse-ld={bfd,gold,lld} but don't prepend "ld." or "ld64." for other values.May 19 2020, 11:04 AM

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
ADT/
2 lines
Support/
8 lines

Diff 258007

View Options

llvm/include/llvm/ADT/StringRef.h

Loading...
View Options

llvm/include/llvm/Support/Compiler.h

Loading...