Page MenuHomePhabricator

Move [[gsl::Pointer]] into llvm/include/llvm/Support/Compiler.h
ClosedPublic

Authored by mgehre on Apr 16 2020, 3:34 AM.

Details

Summary

Make [[gsl::Pointer]] conditional on compiler support

Diff Detail

Event Timeline

mgehre created this revision.Apr 16 2020, 3:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 16 2020, 3:34 AM
Herald added a subscriber: dexonsmith. · View Herald Transcript
mgehre updated this revision to Diff 258007.Apr 16 2020, 3:35 AM

Fix typo

I can confirm this works for MSVC builds

aaron.ballman accepted this revision.Apr 16 2020, 4:51 AM
aaron.ballman added a subscriber: aaron.ballman.

LGTM!

This revision is now accepted and ready to land.Apr 16 2020, 4:51 AM
RKSimon accepted this revision.Apr 16 2020, 4:54 AM

Confirmed on ubuntu gcc7.5 as well - LGTM, cheers.