Page MenuHomePhabricator

[MLIR] NFC after commit D77478.
ClosedPublic

Authored by chelini on Apr 15 2020, 11:12 PM.

Details

Summary

Remove leftovers 'applyPatternsGreedily' from the codebase.

Diff Detail

Event Timeline

chelini created this revision.Apr 15 2020, 11:12 PM
bondhugula accepted this revision.Apr 16 2020, 12:53 AM

Thanks!

This revision is now accepted and ready to land.Apr 16 2020, 12:53 AM
bondhugula added inline comments.Apr 16 2020, 12:54 AM
mlir/lib/Transforms/Inliner.cpp
521

Line wrap to 80 columns.

ftynse accepted this revision.Apr 16 2020, 1:17 AM

I took the liberty to rewrap myself and land.

This revision was automatically updated to reflect the committed changes.

Can you please use a descriptive title for the commit message? Here the description as title Remove leftovers 'applyPatternsGreedily' from the codebase (NFC) would have been more descriptive to me.

Can you please use a descriptive title for the commit message? Here the description as title Remove leftovers 'applyPatternsGreedily' from the codebase (NFC) would have been more descriptive to me.

+1

Can you please use a descriptive title for the commit message? Here the description as title Remove leftovers 'applyPatternsGreedily' from the codebase (NFC) would have been more descriptive to me.

Hi Mehdi,
Yes, I can change the title, but the revision already landed. How should I do this? By re-editing this revision?

Can you please use a descriptive title for the commit message? Here the description as title Remove leftovers 'applyPatternsGreedily' from the codebase (NFC) would have been more descriptive to me.

Hi Mehdi,
Yes, I can change the title, but the revision already landed. How should I do this? By re-editing this revision?

Sorry, I meant "in the future"