This is an archive of the discontinued LLVM Phabricator instance.

Can you please use a descriptive title for the commit message? Here the description as title Remove leftovers 'applyPatternsGreedily' from the codebase (NFC) would have been more descriptive to me.

In D78274#1986831, @mehdi_amini wrote:

Can you please use a descriptive title for the commit message? Here the description as title Remove leftovers 'applyPatternsGreedily' from the codebase (NFC) would have been more descriptive to me.

Hi Mehdi,
Yes, I can change the title, but the revision already landed. How should I do this? By re-editing this revision?

In D78274#1988238, @chelini wrote:

In D78274#1986831, @mehdi_amini wrote:

Can you please use a descriptive title for the commit message? Here the description as title Remove leftovers 'applyPatternsGreedily' from the codebase (NFC) would have been more descriptive to me.

Hi Mehdi,
Yes, I can change the title, but the revision already landed. How should I do this? By re-editing this revision?

Sorry, I meant "in the future"

Revision Contents

Path

Size

mlir/

lib/

Transforms/

Inliner.cpp

2 lines

Utils/

GreedyPatternRewriteDriver.cpp

2 lines

Diff 257963

mlir/lib/Transforms/Inliner.cpp

Show First 20 Lines • Show All 512 Lines • ▼ Show 20 Lines	for (auto *node : currentSCC) {
// require special handling as we may remove the node during		// require special handling as we may remove the node during
// canonicalization. In the future, we should be able to handle this		// canonicalization. In the future, we should be able to handle this
// case with proper node deletion tracking.		// case with proper node deletion tracking.
if (node->hasChildren())		if (node->hasChildren())
continue;		continue;

// We also won't apply canonicalizations for nodes that are not		// We also won't apply canonicalizations for nodes that are not
// isolated. This avoids potentially mutating the regions of nodes defined		// isolated. This avoids potentially mutating the regions of nodes defined
// above, this is also a stipulation of the 'applyPatternsGreedily' driver.		// above, this is also a stipulation of the 'applyPatternsAndFoldGreedily' driver.
		bondhugulaUnsubmitted Not Done Reply Inline Actions Line wrap to 80 columns. bondhugula: Line wrap to 80 columns.
auto *region = node->getCallableRegion();		auto *region = node->getCallableRegion();
if (!region->getParentOp()->isKnownIsolatedFromAbove())		if (!region->getParentOp()->isKnownIsolatedFromAbove())
continue;		continue;
nodesToCanonicalize.push_back(node);		nodesToCanonicalize.push_back(node);
}		}
if (nodesToCanonicalize.empty())		if (nodesToCanonicalize.empty())
return;		return;

▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines

mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp

	//===- GreedyPatternRewriteDriver.cpp - A greedy rewriter -----------------===//			//===- GreedyPatternRewriteDriver.cpp - A greedy rewriter -----------------===//
	//			//
	// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.			// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
	// See https://llvm.org/LICENSE.txt for license information.			// See https://llvm.org/LICENSE.txt for license information.
	// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception			// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
	//			//
	//===----------------------------------------------------------------------===//			//===----------------------------------------------------------------------===//
	//			//
	// This file implements mlir::applyPatternsGreedily.			// This file implements mlir::applyPatternsAndFoldGreedily.
	//			//
	//===----------------------------------------------------------------------===//			//===----------------------------------------------------------------------===//

	#include "mlir/IR/PatternMatch.h"			#include "mlir/IR/PatternMatch.h"
	#include "mlir/Interfaces/SideEffects.h"			#include "mlir/Interfaces/SideEffects.h"
	#include "mlir/Transforms/FoldUtils.h"			#include "mlir/Transforms/FoldUtils.h"
	#include "mlir/Transforms/RegionUtils.h"			#include "mlir/Transforms/RegionUtils.h"
	#include "llvm/ADT/DenseMap.h"			#include "llvm/ADT/DenseMap.h"
	▲ Show 20 Lines • Show All 344 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] NFC after commit D77478.ClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 257963

mlir/lib/Transforms/Inliner.cpp

mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp

[MLIR] NFC after commit D77478.
ClosedPublic