This is an archive of the discontinued LLVM Phabricator instance.

Differential D78274

[MLIR] NFC after commit D77478.
ClosedPublic

Authored by chelini on Apr 15 2020, 11:12 PM.

Details

Reviewers
ftynse
bondhugula
Commits
rGa60fdd2ba487: [MLIR] NFC after commit D77478.
Summary

Remove leftovers 'applyPatternsGreedily' from the codebase.

Diff Detail

Event Timeline

chelini created this revision.Apr 15 2020, 11:12 PM
Herald added subscribers: llvm-commits, frgossen, grosul1 and 14 others. · View Herald TranscriptApr 15 2020, 11:12 PM
Harbormaster failed remote builds in B53511: Diff 257963!Apr 15 2020, 11:25 PM
bondhugula accepted this revision.Apr 16 2020, 12:53 AM

Thanks!

This revision is now accepted and ready to land.Apr 16 2020, 12:53 AM
bondhugula added inline comments.Apr 16 2020, 12:54 AM
mlir/lib/Transforms/Inliner.cpp
521–522

Line wrap to 80 columns.

ftynse accepted this revision.Apr 16 2020, 1:17 AM
ftynse added a comment.Apr 16 2020, 1:32 AM

I took the liberty to rewrap myself and land.

Closed by commit rGa60fdd2ba487: [MLIR] NFC after commit D77478. (authored by chelini, committed by ftynse). · Explain WhyApr 16 2020, 1:35 AM
This revision was automatically updated to reflect the committed changes.
chelini added a comment.Apr 16 2020, 1:35 AM

Thanks.

mehdi_amini added a comment.Apr 16 2020, 8:33 AM

Can you please use a descriptive title for the commit message? Here the description as title Remove leftovers 'applyPatternsGreedily' from the codebase (NFC) would have been more descriptive to me.

bondhugula added a comment.Apr 16 2020, 9:03 AM
In D78274#1986831, @mehdi_amini wrote:

Can you please use a descriptive title for the commit message? Here the description as title Remove leftovers 'applyPatternsGreedily' from the codebase (NFC) would have been more descriptive to me.

+1

chelini added a comment.Apr 17 2020, 12:06 AM
In D78274#1986831, @mehdi_amini wrote:

Can you please use a descriptive title for the commit message? Here the description as title Remove leftovers 'applyPatternsGreedily' from the codebase (NFC) would have been more descriptive to me.

Hi Mehdi,
Yes, I can change the title, but the revision already landed. How should I do this? By re-editing this revision?

mehdi_amini added a comment.Apr 17 2020, 12:59 PM
In D78274#1988238, @chelini wrote:
In D78274#1986831, @mehdi_amini wrote:

Can you please use a descriptive title for the commit message? Here the description as title Remove leftovers 'applyPatternsGreedily' from the codebase (NFC) would have been more descriptive to me.

Hi Mehdi,
Yes, I can change the title, but the revision already landed. How should I do this? By re-editing this revision?

Sorry, I meant "in the future"

Revision Contents

PathSize
mlir/
lib/
Transforms/
3 lines
Utils/
2 lines

Diff 257988

mlir/lib/Transforms/Inliner.cpp

Show First 20 Lines • Show All 512 Lines • ▼ Show 20 Lines for (auto *node : currentSCC) {
// require special handling as we may remove the node during // require special handling as we may remove the node during
// canonicalization. In the future, we should be able to handle this // canonicalization. In the future, we should be able to handle this
// case with proper node deletion tracking. // case with proper node deletion tracking.
if (node->hasChildren()) if (node->hasChildren())
continue; continue;
// We also won't apply canonicalizations for nodes that are not // We also won't apply canonicalizations for nodes that are not
// isolated. This avoids potentially mutating the regions of nodes defined // isolated. This avoids potentially mutating the regions of nodes defined
// above, this is also a stipulation of the 'applyPatternsGreedily' driver. // above, this is also a stipulation of the 'applyPatternsAndFoldGreedily'
// driver.
bondhugulaUnsubmitted
Not Done
ReplyInline Actions

Line wrap to 80 columns.

bondhugula: Line wrap to 80 columns.
auto *region = node->getCallableRegion(); auto *region = node->getCallableRegion();
if (!region->getParentOp()->isKnownIsolatedFromAbove()) if (!region->getParentOp()->isKnownIsolatedFromAbove())
continue; continue;
nodesToCanonicalize.push_back(node); nodesToCanonicalize.push_back(node);
} }
if (nodesToCanonicalize.empty()) if (nodesToCanonicalize.empty())
return; return;
▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines

mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp

//===- GreedyPatternRewriteDriver.cpp - A greedy rewriter -----------------===// //===- GreedyPatternRewriteDriver.cpp - A greedy rewriter -----------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// This file implements mlir::applyPatternsGreedily. // This file implements mlir::applyPatternsAndFoldGreedily.
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include "mlir/IR/PatternMatch.h" #include "mlir/IR/PatternMatch.h"
#include "mlir/Interfaces/SideEffects.h" #include "mlir/Interfaces/SideEffects.h"
#include "mlir/Transforms/FoldUtils.h" #include "mlir/Transforms/FoldUtils.h"
#include "mlir/Transforms/RegionUtils.h" #include "mlir/Transforms/RegionUtils.h"
#include "llvm/ADT/DenseMap.h" #include "llvm/ADT/DenseMap.h"
▲ Show 20 Lines • Show All 344 Lines • Show Last 20 Lines