This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Add 'ptrauth' lit feature
Needs ReviewPublic

Authored by yln on Apr 15 2020, 5:01 PM.

Diff Detail

Event Timeline

yln created this revision.Apr 15 2020, 5:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2020, 5:01 PM
Herald added subscribers: Restricted Project, dberris. · View Herald Transcript

@yln What do you want the ptrauth feature to mean? Right now it means the target is arm64e. I would expect to mean that the toolchain and the target support ptrauth. Right now the patch only checks the target. The patch doesn't check if the toolchain supports it.

What happens if you use a freshly built clang (from llvm-project from llvm.org, not from Swift) for this test? Does it pass? If so I guess my point doesn't matter.

If it doesn't then we might want to a check (probably at CMake configure time) if the toolchain supports ptrauth.