This is an archive of the discontinued LLVM Phabricator instance.

[AArch64ConditionalCompares] Ignore debug insts in findConvertibleCompare [7/10]
ClosedPublic

Authored by vsk on Apr 14 2020, 2:32 PM.

Details

Summary

Fix an issue where the presence of debug info could disable the ccmp
optimization due to findConvertibleCompare failing too early (the error
is "Can't create ccmp with multiple uses", where the "use" is a
DBG_VALUE inst).

Depends on D78151.

Diff Detail

Event Timeline

vsk created this revision.Apr 14 2020, 2:32 PM
aemerson accepted this revision.Apr 14 2020, 4:41 PM

LGTM.

This revision is now accepted and ready to land.Apr 14 2020, 4:41 PM
vsk updated this revision to Diff 257930.Apr 15 2020, 6:28 PM
vsk retitled this revision from [AArch64ConditionalCompares] Ignore debug insts in findConvertibleCompare to [AArch64ConditionalCompares] Ignore debug insts in findConvertibleCompare [7/10].

retitle, use prev_nodbg helper

This revision was automatically updated to reflect the committed changes.