Older review comments at: https://github.com/flang-compiler/f18/pull/1065
I have no idea :) the precommit on phabricator is very new and I haven't looked in to it at all. Most CI is focussed on BuildBots which run after commit, and those just have whatever flags the person hosting it have set. I wouldn't worry about it too much at the moment, we need to discuss what is going on with the folks that set them up.
Above doxygen patch seems to fail for me for below flags
As it tries to copy <path to build>/docs/html to <path to install prefix>/docs the same error for out-of-tree reported (here) which I tried to fix for out-of-tree builds (here)
Now that we are in tree, things seem to have dependency on mlir and llvm as well.
llvm-project/mlir as well shows the same error.
When adding the dependency (here) to llvm and mlir docs/CMakeLists.txt seems to fix error.
@sscalpone is that the expected way how the doxygen is tested in other llvm umbrella projects or am I testing it in wrong way?
@jdoerfert does clang and mlir also have the similar issue, which needs to be fixed, as adding a fix in these projects seems to solve issue in flang ?
Expected behavior should not build nor install any documentation and documentation targets(doxygen-flang) should not be visible.
Whereas adding LLVM_INCLUDE_DOCS=OFF and MLIR_INCLUDE_DOCS=OFF seems to work fine.
But does anyone have an idea on the appropriate flags for generating doxygen based documentation, as the number of permutations could be huge to test based on llvm and mlir flags?
The CMakeLists.txt file has
if (FLANG_INCLUDE_DOCS) add_subdirectory(docs) endif()
IIUC the working of CMake I think the docs/ sub directory won't be added hence no docs/CMakeLists.txt would be present.