Update lowering to match the comment in IntrinsicsAMDGPU.td and
GlobalISel FDIV lowering. Also see https://reviews.llvm.org/D77547
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.div.scale.ll | ||
---|---|---|
21 | DAG lowering was wrong. I thought we never used the intrinsic directly so it didn't matter. |
llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.div.scale.ll | ||
---|---|---|
21 | I think this is really "comment is wrong". In case there are any users, we should maintain the current behavior |
llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.div.scale.ll | ||
---|---|---|
21 | I thought we were sure it wasn't being used.. Seems like we would have heard about it otherwise. Anyway I agree it's safer to change the comment and the GlobalISel FDIV lowering so I'll abandon this. |
Is there an isNull or something to use instead of negate?