[test-suite] Move lit test result codes into llvm/lit

[jdoerfert]

Summary

In D77986 we moved these result codes into llvm/lit, now we use
those definitions directly.

Depends on: D77986

[yln]

litsupport/test.py

38

I think the existing category of UNRESOLVED would be a good semantic fit here.

[jdoerfert]

litsupport/test.py

38

I mentioned something similar in the other review [0] but FTR:

To me, unresolved doesn't capture the fact that the compile stage of the (lnt-based) process failed to produce an executable. Unresolved is a generic term which could mean a lo of things, e.g., some system dependence were missing, the architecture did not match, the source download failed, ...

[0] https://reviews.llvm.org/D77986#1979402

litsupport/test.py

 """
 Main integration for llvm-lit: This defines a lit test format.
 Also contains logic to load benchmark modules.
 """
 import lit
 import lit.TestRunner
 import lit.util
 import lit.formats
 import litsupport.modules
 import litsupport.modules.hash
 import litsupport.testfile
 import litsupport.testplan
 import os
 
 
-SKIPPED = lit.Test.ResultCode('SKIPPED', False)
-NOEXE = lit.Test.ResultCode('NOEXE', True)
-
 
 class TestSuiteTest(lit.formats.ShTest):
     def __init__(self):
         super(TestSuiteTest, self).__init__()
 
     def execute(self, test, litConfig):
         config = test.config
         if config.unsupported:
             return lit.Test.Result(lit.Test.UNSUPPORTED, 'Test is unsupported')
         if litConfig.noExecute:
             return lit.Test.Result(lit.Test.PASS)
 
         # Parse .test file and initialize context
         tmpDir, tmpBase = lit.TestRunner.getTempPaths(test)
         lit.util.mkdir_p(os.path.dirname(tmpBase))
         context = litsupport.testplan.TestContext(test, litConfig, tmpDir,
                                                   tmpBase)
         litsupport.testfile.parse(context, test.getSourcePath())
         plan = litsupport.testplan.TestPlan()
 
         # Report missing test executables.
         if not os.path.exists(context.executable):
-            return lit.Test.Result(NOEXE, "Executable '%s' is missing" %
+            return lit.Test.Result(lit.Test.NOEXE, "Executable '%s' is missing" %
                                    context.executable)
 
         # Skip unchanged tests
         if config.previous_results:
             litsupport.modules.hash.compute(context)
             if litsupport.modules.hash.same_as_previous(context):
                 result = lit.Test.Result(
-                        SKIPPED, 'Executable identical to previous run')
+                        lit.Test.SKIPPED, 'Executable identical to previous run')
                 val = lit.Test.toMetricValue(context.executable_hash)
                 result.addMetric('hash', val)
                 return result
 
         # Let test modules modify the test plan.
         for modulename in config.test_modules:
             module = litsupport.modules.modules.get(modulename)
             if module is None:
                 raise Exception("Unknown testmodule '%s'" % modulename)
             module.mutatePlan(context, plan)
 
         # Execute Test plan
         result = litsupport.testplan.executePlanTestResult(context, plan)
 
         return result